Add --stable-release-mode to content_shell

Add --stable-release-mode to content_shell

The new flag is used to force testing content_shell with only stable
flags enabled, which will enable testing what is exposed in stable.

As part of this change, moved the "test" runtime features enabling
into ShellRenderProcessObserver. This is a good step as TestInterfaces
(that handles this now) doesn't know about which flags are passed on
the command line.

The change is not testable right now as it requires some changes in
TestInterfaces in Blink to avoid enabling all the flags.

BUG=234853
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218603

[eseidel, 2013-08-19 23:27:06]

lgtm

Seems OK to me.  Jochen is probably a better reviewer for this though.

https://codereview.chromium.org/22799014/diff/1/content/shell/common/shell_sw...
File content/shell/common/shell_switches.cc (right):

https://codereview.chromium.org/22799014/diff/1/content/shell/common/shell_sw...
content/shell/common/shell_switches.cc:39: //
http://dev.chromium.org/blink/runtime-enabled-features.
Should you note that this flag only does anything when --dump-render-tree is
passed?

https://codereview.chromium.org/22799014/diff/1/content/shell/renderer/shell_...
File content/shell/renderer/shell_render_process_observer.cc (right):

https://codereview.chromium.org/22799014/diff/1/content/shell/renderer/shell_...
content/shell/renderer/shell_render_process_observer.cc:73: if
(!CommandLine::ForCurrentProcess()->HasSwitch(
81c?

[Julien - ping for review, 2013-08-19 23:43:04]

https://codereview.chromium.org/22799014/diff/1/content/shell/common/shell_sw...
File content/shell/common/shell_switches.cc (right):

https://codereview.chromium.org/22799014/diff/1/content/shell/common/shell_sw...
content/shell/common/shell_switches.cc:39: //
http://dev.chromium.org/blink/runtime-enabled-features.
On 2013/08/19 23:27:07, eseidel wrote:
> Should you note that this flag only does anything when --dump-render-tree is
> passed?

Makes sense, updated the comment.

https://codereview.chromium.org/22799014/diff/1/content/shell/renderer/shell_...
File content/shell/renderer/shell_render_process_observer.cc (right):

https://codereview.chromium.org/22799014/diff/1/content/shell/renderer/shell_...
content/shell/renderer/shell_render_process_observer.cc:73: if
(!CommandLine::ForCurrentProcess()->HasSwitch(
On 2013/08/19 23:27:07, eseidel wrote:
> 81c?

You got it.

[jochen (gone - plz use gerrit), 2013-08-20 08:24:33]

lgtm

https://codereview.chromium.org/22799014/diff/13001/content/shell/renderer/sh...
File content/shell/renderer/shell_render_process_observer.cc (right):

https://codereview.chromium.org/22799014/diff/13001/content/shell/renderer/sh...
content/shell/renderer/shell_render_process_observer.cc:74:
switches::kStableReleaseMode))
nit. add { } please

[Julien - ping for review, 2013-08-20 14:49:36]

Thanks Jochen!

https://codereview.chromium.org/22799014/diff/13001/content/shell/renderer/sh...
File content/shell/renderer/shell_render_process_observer.cc (right):

https://codereview.chromium.org/22799014/diff/13001/content/shell/renderer/sh...
content/shell/renderer/shell_render_process_observer.cc:74:
switches::kStableReleaseMode))
On 2013/08/20 08:24:33, jochen wrote:
> nit. add { } please

Done.

[commit-bot: I haz the power, 2013-08-20 14:49:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22799014/24001

[commit-bot: I haz the power, 2013-08-20 17:15:47]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-08-20 20:02:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22799014/24001

[commit-bot: I haz the power, 2013-08-21 02:43:57]

Change committed as 218603