I'm investigating how to make the IPC transfer a bit more secure on the

src/core/SkOrderedReadBuffer.cpp

Index: src/core/SkOrderedReadBuffer.cpp
diff --git a/src/core/SkOrderedReadBuffer.cpp b/src/core/SkOrderedReadBuffer.cpp
index 9d991949084e5b9586d57baeaadf72363eb3e3ef..6028c231f80d44eb33107af5ee6d459501f54c60 100644
--- a/src/core/SkOrderedReadBuffer.cpp
+++ b/src/core/SkOrderedReadBuffer.cpp
@@ -288,8 +288,8 @@ SkFlattenable* SkOrderedReadBuffer::readFlattenable() {
         factory = (*fFactoryTDArray)[index];
     } else {
         factory = (SkFlattenable::Factory)readFunctionPtr();
-        if (NULL == factory) {
-            return NULL; // writer failed to give us the flattenable
+        if (NULL == factory || NULL == SkFlattenable::FactoryToName(factory)) {

[sugoi, 2013/08/16 20:58:46]

I quickly realized that using SkFlattenable::FactoryToName() wasn't going to
work since not all flattenable objects use the Registrar interface, but I think
we need some way of not simply reading and calling a function pointer, for
security reasons.

+            return NULL; // writer failed to give us a valid factory
         }
     }
 

[sugoi, 2013/08/13 15:20:26]

At this point, if possible, I'd like to be able to reset the factory to NULL if
the factory isn't of the right "type". For example, this function could have
some sort of mask or filter as input which only allows certain factory functions
to be used. That may be overkill, but why read objects if we know we're going to
discard them later ?