Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 22799003: Added DEPS files to //chrome/browser/policy. (Closed)

Created:
7 years, 4 months ago by Joao da Silva
Modified:
7 years, 4 months ago
CC:
chromium-reviews, Jói
Visibility:
Public.

Description

Added DEPS files to //chrome/browser/policy. Part of this code will be moved into a layered component, and these DEPS checks will make sure no new dependencies are introduced. BUG=271392 R=mnissler@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216996

Patch Set 1 #

Total comments: 5

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -0 lines) Patch
A chrome/browser/policy/DEPS View 1 chunk +155 lines, -0 lines 0 comments Download
A chrome/browser/policy/cloud/DEPS View 1 chunk +162 lines, -0 lines 0 comments Download
A chrome/browser/policy/test/DEPS View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Joao da Silva
Please have a quick look. This was generated by a script and then the files ...
7 years, 4 months ago (2013-08-12 14:46:08 UTC) #1
Mattias Nissler (ping if slow)
LGTM as long as stuff still builds :) https://codereview.chromium.org/22799003/diff/1/chrome/browser/policy/DEPS File chrome/browser/policy/DEPS (right): https://codereview.chromium.org/22799003/diff/1/chrome/browser/policy/DEPS#newcode26 chrome/browser/policy/DEPS:26: "+chromeos", ...
7 years, 4 months ago (2013-08-12 14:52:38 UTC) #2
Joao da Silva
Thanks for the review! https://codereview.chromium.org/22799003/diff/1/chrome/browser/policy/DEPS File chrome/browser/policy/DEPS (right): https://codereview.chromium.org/22799003/diff/1/chrome/browser/policy/DEPS#newcode26 chrome/browser/policy/DEPS:26: "+chromeos", On 2013/08/12 14:52:38, Mattias ...
7 years, 4 months ago (2013-08-12 15:03:29 UTC) #3
Mattias Nissler (ping if slow)
https://codereview.chromium.org/22799003/diff/1/chrome/browser/policy/cloud/DEPS File chrome/browser/policy/cloud/DEPS (right): https://codereview.chromium.org/22799003/diff/1/chrome/browser/policy/cloud/DEPS#newcode28 chrome/browser/policy/cloud/DEPS:28: "+chromeos", On 2013/08/12 15:03:29, Joao da Silva wrote: > ...
7 years, 4 months ago (2013-08-12 15:13:49 UTC) #4
Joao da Silva
Committed patchset #2 manually as r216996.
7 years, 4 months ago (2013-08-12 15:21:48 UTC) #5
Joao da Silva
+Jói FYI We plan to reduce the number of exceptions. These DEPS were added to ...
7 years, 4 months ago (2013-08-12 15:22:46 UTC) #6
Jói
7 years, 4 months ago (2013-08-12 15:27:50 UTC) #7
Message was sent while issue was closed.
Cool!

Powered by Google App Engine
This is Rietveld 408576698