Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2279873002: Revert of Use ScaleToEnclosingRect when converting the viewport to window. (Closed)

Created:
4 years, 3 months ago by lfg
Modified:
4 years, 3 months ago
Reviewers:
oshima, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use ScaleToEnclosingRect when converting the viewport to window. (patchset #1 id:1 of https://codereview.chromium.org/2258493002/ ) Reason for revert: This seems to have broken virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance.html. Original issue's description: > Use ScaleToEnclosingRect when converting the viewport to window. > > This guarantees that the viewport is always contained in the window. > > BUG=none > > Committed: https://crrev.com/88fd07f9af5311a6e85502aedca5ce94c9ddfe23 > Cr-Commit-Position: refs/heads/master@{#414452} TBR=oshima@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/15b235a3d943722097ac5e050251a009ec341f28 Cr-Commit-Position: refs/heads/master@{#414469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/renderer/render_widget.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
lfg
Created Revert of Use ScaleToEnclosingRect when converting the viewport to window.
4 years, 3 months ago (2016-08-25 17:44:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279873002/1
4 years, 3 months ago (2016-08-25 17:45:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 17:46:08 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 17:47:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15b235a3d943722097ac5e050251a009ec341f28
Cr-Commit-Position: refs/heads/master@{#414469}

Powered by Google App Engine
This is Rietveld 408576698