[chromecast] Enables mojo:media everywhere.

[chromecast] Enables mojo:media everywhere.

We had already enabled it on chromecast devices. This patch enables
it on desktop as well to gain test coverage on cast-linux buildbot.
The caveat for developers testing media on desktop is that only
audio works since the media service on desktop does not support
video yet.

BUG=571155
Committed: https://crrev.com/3445a2e7e606e5d71e281d957bda96aeafdfc4f5
Cr-Commit-Position: refs/heads/master@{#416102}

[alokp, 2016-08-25 23:00:26]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 23:01:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alokp, 2016-08-26 00:00:11]

alokp@chromium.org changed reviewers:
+ halliwell@chromium.org, xhwang@chromium.org

[xhwang, 2016-08-26 00:02:32]

woohoo! I <3 this CL!

LGTM

[halliwell, 2016-08-26 00:08:21]

On 2016/08/26 00:02:32, xhwang (slow) wrote:
> woohoo! I <3 this CL!
> 
> LGTM

lgtm, can you also add a note to docs/cast_build_instructions.md about the
desktop issue?

[commit-bot: I haz the power, 2016-08-26 01:16:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 01:16:53]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alokp, 2016-08-26 05:17:44]

Not so fast :(

I hit a snag with media-related content_browsertests on the cast_shell_linux
bot, which builds targets with is_chromecast=true, which in turn enables
mojo-media. Since the DefaultMojoMediaClient, used on desktop, returns a null
Renderer, pipeline initialization fails.

It looks like TestMojoMediaClient is much more capable compared to
DefaultMojoMediaClient. I will see how far I can get with using
TestMojoMediaClient instead.

xhwang@: Any objection to using TestMojoMediaClient for content_browsertests?

[xhwang, 2016-08-26 17:13:10]

On 2016/08/26 05:17:44, alokp wrote:
> Not so fast :(
> 
> I hit a snag with media-related content_browsertests on the cast_shell_linux
> bot, which builds targets with is_chromecast=true, which in turn enables
> mojo-media. Since the DefaultMojoMediaClient, used on desktop, returns a null
> Renderer, pipeline initialization fails.
> 
> It looks like TestMojoMediaClient is much more capable compared to
> DefaultMojoMediaClient. I will see how far I can get with using
> TestMojoMediaClient instead.
> 
> xhwang@: Any objection to using TestMojoMediaClient for content_browsertests?

It makes a lot of sense to me to use TestMojoMediaClient for
content_browsertests. I am also adding a content_browsertest using mojo:media on
Android (https://chromiumcodereview.appspot.com/2268283003/). Currently we do
have a real MojoMediaClient on Android so I don't have this issue.

[alokp, 2016-09-01 20:49:30]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:49:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:54:22]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alokp, 2016-09-01 20:56:07]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-09-01 20:56:07]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2279863003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-01 20:56:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 22:56:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-01 22:58:52]

Description was changed from

==========
[chromecast] Enables mojo:media everywhere.

We had already enabled it on chromecast devices. This patch enables
it on desktop as well to gain test coverage on cast-linux buildbot.
The caveat for developers testing media on desktop is that only
audio works since the media service on desktop does not support
video yet.

BUG=571155
==========

to

==========
[chromecast] Enables mojo:media everywhere.

We had already enabled it on chromecast devices. This patch enables
it on desktop as well to gain test coverage on cast-linux buildbot.
The caveat for developers testing media on desktop is that only
audio works since the media service on desktop does not support
video yet.

BUG=571155

Committed: https://crrev.com/3445a2e7e606e5d71e281d957bda96aeafdfc4f5
Cr-Commit-Position: refs/heads/master@{#416102}
==========

[commit-bot: I haz the power, 2016-09-01 22:58:53]

Patchset 2 (id:??) landed as
https://crrev.com/3445a2e7e606e5d71e281d957bda96aeafdfc4f5
Cr-Commit-Position: refs/heads/master@{#416102}