Use LayoutSVGResourceClipper::resourceBoundingBox() in ClipPathClipper

Use LayoutSVGResourceClipper::resourceBoundingBox() in ClipPathClipper

Use the reference box to compute the clip-path bounds in ClipPathClipper,
using the resourceBoundingBox() method from LayoutSVGResourceClipper. This
should give reasonably tight-fitting bounds for the clip-as-mask code-path
which uses these bounds. It also means one less item to pass around.

This means that the clip-path code in PaintLayerPainter no longer needs
the |rootRelativeBounds| and associated bool, so that code can be pushed
down into FilterPainter with additional plumbing simplifications.

Also straighten out the code-flow in ClipPathClipper for less indented,
and hopefully easier to follow, code.

BUG=633028, 626097
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/422862958695797596356c0bb1d6f0e964f9ee83
Cr-Commit-Position: refs/heads/master@{#416073}

[fs, 2016-08-25 16:16:21]

Description was changed from

==========
Use LayoutSVGResourceClipper::resourceBoundingBox in ClipPathClipper

Straighten out code-flow in ClipPathClipper.

BUG=633028, 418484
==========

to

==========
Use LayoutSVGResourceClipper::resourceBoundingBox in ClipPathClipper

Straighten out code-flow in ClipPathClipper.

BUG=633028, 418484
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-08-25 16:16:38]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 16:17:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 18:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 18:03:50]

Dry run: This issue passed the CQ dry run.

[fs, 2016-08-25 18:10:38]

Description was changed from

==========
Use LayoutSVGResourceClipper::resourceBoundingBox in ClipPathClipper

Straighten out code-flow in ClipPathClipper.

BUG=633028, 418484
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use LayoutSVGResourceClipper::resourceBoundingBox() in ClipPathClipper

Use the reference box to compute the clip-path bounds in ClipPathClipper,
using the resourceBoundingBox() method from LayoutSVGResourceClipper. This
should give reasonably tight-fitting bounds for the clip-as-mask code-path
which uses these bounds. It also means one less item to pass around.

Also straighten out the code-flow in ClipPathClipper for less indented,
and hopefully easier to follow, code.

BUG=633028, 418484
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-08-25 18:11:26]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[fs, 2016-08-25 18:11:27]

Maybe I'll end up regretting this, but it did feel like a good idea at least
earlier today... Let me know what you think.

[fs, 2016-08-25 18:13:46]

Description was changed from

==========
Use LayoutSVGResourceClipper::resourceBoundingBox() in ClipPathClipper

Use the reference box to compute the clip-path bounds in ClipPathClipper,
using the resourceBoundingBox() method from LayoutSVGResourceClipper. This
should give reasonably tight-fitting bounds for the clip-as-mask code-path
which uses these bounds. It also means one less item to pass around.

Also straighten out the code-flow in ClipPathClipper for less indented,
and hopefully easier to follow, code.

BUG=633028, 418484
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use LayoutSVGResourceClipper::resourceBoundingBox() in ClipPathClipper

Use the reference box to compute the clip-path bounds in ClipPathClipper,
using the resourceBoundingBox() method from LayoutSVGResourceClipper. This
should give reasonably tight-fitting bounds for the clip-as-mask code-path
which uses these bounds. It also means one less item to pass around.

This means that the clip-path code in PaintLayerPainter no longer needs
the |rootRelativeBounds| and associated bool, so that code can be pushed
down into FilterPainter with additional plumbing simplifications.

Also straighten out the code-flow in ClipPathClipper for less indented,
and hopefully easier to follow, code.

BUG=633028, 418484
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-08-25 20:30:45]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[pdr., 2016-08-25 20:35:55]

On 2016/08/25 at 18:11:27, fs wrote:
> Maybe I'll end up regretting this, but it did feel like a good idea at least
earlier today... Let me know what you think.

I was just in the PaintLayerPainter code for
https://codereview.chromium.org/2276283002 and did not like that code. I like
those changes.

The bounds change is a change in behavior. Can that be tested (for 633028)?

[fs, 2016-08-25 22:34:11]

On 2016/08/25 at 20:35:55, pdr wrote:
> On 2016/08/25 at 18:11:27, fs wrote:
> > Maybe I'll end up regretting this, but it did feel like a good idea at least
earlier today... Let me know what you think.
> 
> I was just in the PaintLayerPainter code for
https://codereview.chromium.org/2276283002 and did not like that code. I like
those changes.

Yes, that code is Sasquatch-land...

> The bounds change is a change in behavior. Can that be tested (for 633028)?

There should not be any web-exposed behavioral change in here. The cull rect is
different though. Regardless, with all filter bounds bugs being handled ATM (the
above and crbug.com/638091) it may well be best to sit on this for a bit to not
stir the pot too much.

[pdr., 2016-08-26 01:39:54]

On 2016/08/25 at 22:34:11, fs wrote:
> On 2016/08/25 at 20:35:55, pdr wrote:
> > On 2016/08/25 at 18:11:27, fs wrote:
> > > Maybe I'll end up regretting this, but it did feel like a good idea at
least earlier today... Let me know what you think.
> > 
> > I was just in the PaintLayerPainter code for
https://codereview.chromium.org/2276283002 and did not like that code. I like
those changes.
> 
> Yes, that code is Sasquatch-land...
> 
> > The bounds change is a change in behavior. Can that be tested (for 633028)?

(Oops, I meant 418484, not 633028)

> 
> There should not be any web-exposed behavioral change in here. The cull rect
is different though. Regardless, with all filter bounds bugs being handled ATM
(the above and crbug.com/638091) it may well be best to sit on this for a bit to
not stir the pot too much.

Ahh, this is just a cleanup / bounds improvement and not a behavior change.

Reading 638091... we're probably going to branch today or early tomorrow for
m54. To make senorblanco's merge a little easier, I agree it would be nice to
wait a couple days.

LGTM though.

[fs, 2016-08-29 09:16:58]

Description was changed from

==========
Use LayoutSVGResourceClipper::resourceBoundingBox() in ClipPathClipper

Use the reference box to compute the clip-path bounds in ClipPathClipper,
using the resourceBoundingBox() method from LayoutSVGResourceClipper. This
should give reasonably tight-fitting bounds for the clip-as-mask code-path
which uses these bounds. It also means one less item to pass around.

This means that the clip-path code in PaintLayerPainter no longer needs
the |rootRelativeBounds| and associated bool, so that code can be pushed
down into FilterPainter with additional plumbing simplifications.

Also straighten out the code-flow in ClipPathClipper for less indented,
and hopefully easier to follow, code.

BUG=633028, 418484
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use LayoutSVGResourceClipper::resourceBoundingBox() in ClipPathClipper

Use the reference box to compute the clip-path bounds in ClipPathClipper,
using the resourceBoundingBox() method from LayoutSVGResourceClipper. This
should give reasonably tight-fitting bounds for the clip-as-mask code-path
which uses these bounds. It also means one less item to pass around.

This means that the clip-path code in PaintLayerPainter no longer needs
the |rootRelativeBounds| and associated bool, so that code can be pushed
down into FilterPainter with additional plumbing simplifications.

Also straighten out the code-flow in ClipPathClipper for less indented,
and hopefully easier to follow, code.

BUG=633028, 626097
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-08-30 13:22:16]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 13:22:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 14:46:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 14:46:12]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-01 12:32:15]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 12:32:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 14:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 14:49:56]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-01 21:48:48]

The CQ bit was checked by fs@opera.com

[fs, 2016-09-01 21:48:49]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2279823002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-01 21:49:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 21:54:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 21:57:36]

Description was changed from

==========
Use LayoutSVGResourceClipper::resourceBoundingBox() in ClipPathClipper

Use the reference box to compute the clip-path bounds in ClipPathClipper,
using the resourceBoundingBox() method from LayoutSVGResourceClipper. This
should give reasonably tight-fitting bounds for the clip-as-mask code-path
which uses these bounds. It also means one less item to pass around.

This means that the clip-path code in PaintLayerPainter no longer needs
the |rootRelativeBounds| and associated bool, so that code can be pushed
down into FilterPainter with additional plumbing simplifications.

Also straighten out the code-flow in ClipPathClipper for less indented,
and hopefully easier to follow, code.

BUG=633028, 626097
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use LayoutSVGResourceClipper::resourceBoundingBox() in ClipPathClipper

Use the reference box to compute the clip-path bounds in ClipPathClipper,
using the resourceBoundingBox() method from LayoutSVGResourceClipper. This
should give reasonably tight-fitting bounds for the clip-as-mask code-path
which uses these bounds. It also means one less item to pass around.

This means that the clip-path code in PaintLayerPainter no longer needs
the |rootRelativeBounds| and associated bool, so that code can be pushed
down into FilterPainter with additional plumbing simplifications.

Also straighten out the code-flow in ClipPathClipper for less indented,
and hopefully easier to follow, code.

BUG=633028, 626097
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/422862958695797596356c0bb1d6f0e964f9ee83
Cr-Commit-Position: refs/heads/master@{#416073}
==========

[commit-bot: I haz the power, 2016-09-01 21:57:37]

Patchset 3 (id:??) landed as
https://crrev.com/422862958695797596356c0bb1d6f0e964f9ee83
Cr-Commit-Position: refs/heads/master@{#416073}