Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 22798004: Randomize mach_override_ptr trampoline addresses on 32-bit (Closed)

Created:
7 years, 4 months ago by ianbeer
Modified:
7 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Randomize mach_override_ptr trampoline addresses on 32-bit BUG=265731 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217238

Patch Set 1 #

Patch Set 2 : Add changes to README.chromium #

Patch Set 3 : Use VM_FLAGS_ANYWHERE rather than 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M third_party/mach_override/README.chromium View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mach_override/mach_override.c View 1 2 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ianbeer
This randomizes the locations of the mach_override_ptr trampolines on 32 bit. Doing it for 64 ...
7 years, 4 months ago (2013-08-12 13:40:22 UTC) #1
Mark Mentovai
LGTM
7 years, 4 months ago (2013-08-12 14:13:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ianbeer@chromium.org/22798004/5001
7 years, 4 months ago (2013-08-12 14:18:06 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=186534
7 years, 4 months ago (2013-08-12 18:15:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ianbeer@chromium.org/22798004/5001
7 years, 4 months ago (2013-08-13 07:55:04 UTC) #5
commit-bot: I haz the power
Change committed as 217238
7 years, 4 months ago (2013-08-13 11:53:46 UTC) #6
Mark Mentovai
7 years, 1 month ago (2013-11-06 02:57:15 UTC) #7
Message was sent while issue was closed.
This hasn’t been upstreamed to https://github.com/rentzsch/mach_override yet.
Please upstream it.

Powered by Google App Engine
This is Rietveld 408576698