Convert LayoutTests/fast/canvas/2d tests to testharness.

Convert LayoutTests/fast/canvas/2d tests to testharness.

This patch uses testharness.js asserts to test
2d.text.draw.fill.maxWidth.gradient.html,
2d.text.draw.fill.maxWidth.negative-expected.html.
Remove the expectation files as they are not needed any more.

BUG=639732
Committed: https://crrev.com/c8e5feee42203a2441e25c518d9ce06fed879834
Cr-Commit-Position: refs/heads/master@{#414912}

[sivag, 2016-08-26 06:02:18]

Description was changed from

==========
Convert LayoutTests/fast/canvas/2d tests to testharness.

This patch uses testharness.js asserts to test
2d.text.draw.fill.maxWidth.gradient.html,
2d.text.draw.fill.maxWidth.negative-expected.html.
Remove the expectation files as they are not needed any more.

BUG=639732
==========

to

==========
Convert LayoutTests/fast/canvas/2d tests to testharness.

This patch uses testharness.js asserts to test
2d.text.draw.fill.maxWidth.gradient.html,
2d.text.draw.fill.maxWidth.negative-expected.html.
Remove the expectation files as they are not needed any more.

BUG=639732
==========

[sivag, 2016-08-26 06:02:18]

siva.gunturi@samsung.com changed reviewers:
+ fs@opera.com, junov@chromium.org, srirama.m@samsung.com

[sivag, 2016-08-26 06:02:26]

ptal..

[sivag, 2016-08-26 06:02:44]

Description was changed from

==========
Convert LayoutTests/fast/canvas/2d tests to testharness.

This patch uses testharness.js asserts to test
2d.text.draw.fill.maxWidth.gradient.html,
2d.text.draw.fill.maxWidth.negative-expected.html.
Remove the expectation files as they are not needed any more.

BUG=639732
==========

to

==========
Convert LayoutTests/fast/canvas/2d tests to testharness.

This patch uses testharness.js asserts to test
2d.text.draw.fill.maxWidth.gradient.html,
2d.text.draw.fill.maxWidth.negative-expected.html.
Remove the expectation files as they are not needed any more.

BUG=639732
==========

[fs, 2016-08-26 09:13:18]

LGTM w/ nits

https://codereview.chromium.org/2279763002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.gradient.html
(right):

https://codereview.chromium.org/2279763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.gradient.html:11:
<canvas width="100" height="100">
I think it would be preferable to close the </canvas> here (rather than
implicitly at the end of the file.)

https://codereview.chromium.org/2279763002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.negative.html
(right):

https://codereview.chromium.org/2279763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.negative.html:2:
<title>Test that color gets applied properly with canvas2d text drawing when
filled with negative maxwidth..</title>
Nit: Double . (Since this is a title, I believe we technically don't need any at
all...)

https://codereview.chromium.org/2279763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.negative.html:11:
<canvas width="100" height="100">
Same as the other test.

[sivag, 2016-08-26 10:01:35]

ptal..

https://codereview.chromium.org/2279763002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.gradient.html
(right):

https://codereview.chromium.org/2279763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.gradient.html:11:
<canvas width="100" height="100">
On 2016/08/26 09:13:18, fs wrote:
> I think it would be preferable to close the </canvas> here (rather than
> implicitly at the end of the file.)

Done.

https://codereview.chromium.org/2279763002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.negative.html
(right):

https://codereview.chromium.org/2279763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.negative.html:2:
<title>Test that color gets applied properly with canvas2d text drawing when
filled with negative maxwidth..</title>
On 2016/08/26 09:13:18, fs wrote:
> Nit: Double . (Since this is a title, I believe we technically don't need any
at
> all...)

Done.

https://codereview.chromium.org/2279763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.negative.html:11:
<canvas width="100" height="100">
On 2016/08/26 09:13:18, fs wrote:
> Same as the other test.

Done.

[fs, 2016-08-26 10:33:59]

On 2016/08/26 at 10:01:35, siva.gunturi wrote:
> ptal..

Still lgtm

[sivag, 2016-08-26 10:34:34]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2016-08-26 10:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sivag, 2016-08-26 10:35:21]

The CQ bit was unchecked by siva.gunturi@samsung.com

[sivag, 2016-08-27 02:03:17]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2016-08-27 02:04:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 10:57:46]

Description was changed from

==========
Convert LayoutTests/fast/canvas/2d tests to testharness.

This patch uses testharness.js asserts to test
2d.text.draw.fill.maxWidth.gradient.html,
2d.text.draw.fill.maxWidth.negative-expected.html.
Remove the expectation files as they are not needed any more.

BUG=639732
==========

to

==========
Convert LayoutTests/fast/canvas/2d tests to testharness.

This patch uses testharness.js asserts to test
2d.text.draw.fill.maxWidth.gradient.html,
2d.text.draw.fill.maxWidth.negative-expected.html.
Remove the expectation files as they are not needed any more.

BUG=639732
==========

[commit-bot: I haz the power, 2016-08-27 10:57:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-27 10:59:30]

Description was changed from

==========
Convert LayoutTests/fast/canvas/2d tests to testharness.

This patch uses testharness.js asserts to test
2d.text.draw.fill.maxWidth.gradient.html,
2d.text.draw.fill.maxWidth.negative-expected.html.
Remove the expectation files as they are not needed any more.

BUG=639732
==========

to

==========
Convert LayoutTests/fast/canvas/2d tests to testharness.

This patch uses testharness.js asserts to test
2d.text.draw.fill.maxWidth.gradient.html,
2d.text.draw.fill.maxWidth.negative-expected.html.
Remove the expectation files as they are not needed any more.

BUG=639732

Committed: https://crrev.com/c8e5feee42203a2441e25c518d9ce06fed879834
Cr-Commit-Position: refs/heads/master@{#414912}
==========

[commit-bot: I haz the power, 2016-08-27 10:59:31]

Patchset 4 (id:??) landed as
https://crrev.com/c8e5feee42203a2441e25c518d9ce06fed879834
Cr-Commit-Position: refs/heads/master@{#414912}