Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2279753003: Move definition of PasswordType enum to a separate header. (Closed)

Created:
4 years, 3 months ago by melandory
Modified:
4 years, 3 months ago
Reviewers:
stevenjb, Nicolas Zea
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@passphrase-type-enum-class
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move definition of PasswordType enum to a separate header. BUG=638963 Committed: https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135 Cr-Commit-Position: refs/heads/master@{#415425}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : get rid of PassphraseType::UNDEFINED #

Patch Set 4 : D2279753003 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -17 lines) Patch
M chrome/browser/ui/webui/settings/people_handler.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A components/sync/base/passphrase_type.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A components/sync/base/passphrase_type.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M components/sync/core/sync_encryption_handler.h View 2 chunks +1 line, -12 lines 0 comments Download
M components/sync/core_impl/js_sync_encryption_handler_observer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/core_impl/sync_encryption_handler_impl.cc View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download
M components/sync/engine/sync_status.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/engine/sync_string_conversions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync/engine/sync_string_conversions.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/test/fake_sync_encryption_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
melandory
PTAL. This CL is part of CLs chain described in last mail here: https://codereview.chromium.org/2260953002
4 years, 3 months ago (2016-08-26 16:01:13 UTC) #7
Nicolas Zea
lgtm
4 years, 3 months ago (2016-08-26 23:29:54 UTC) #8
melandory
stevenjb@chromium.org: Please review changes in c/b/ui/webui
4 years, 3 months ago (2016-08-26 23:34:04 UTC) #10
stevenjb
c/b/ui/webui RS lgtm
4 years, 3 months ago (2016-08-29 15:40:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279753003/60001
4 years, 3 months ago (2016-08-30 18:09:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/287532)
4 years, 3 months ago (2016-08-30 18:13:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279753003/80001
4 years, 3 months ago (2016-08-30 18:44:15 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 3 months ago (2016-08-30 21:10:20 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:11:57 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8d67cd89ff721b10093918374e35c892986fa135
Cr-Commit-Position: refs/heads/master@{#415425}

Powered by Google App Engine
This is Rietveld 408576698