Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2279703003: GN: mac host and armv7 target (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
herb_g
CC:
jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: mac host and armv7 target Just when I thought it wouldn't be useful to override ar... Tested by building 32- and 64-bit DM on my MBP and running it on my N5x. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2279703003 Committed: https://skia.googlesource.com/skia/+/349cecefe21e2b45acc201290cc4e4fa93b4ad76

Patch Set 1 #

Patch Set 2 : EGL sync is 18+... how are we doing this with 14 today? #

Patch Set 3 : ugly #

Patch Set 4 : rest #

Patch Set 5 : mips for real #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -17 lines) Patch
M BUILD.gn View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M gn/BUILD.gn View 1 2 3 4 5 chunks +24 lines, -6 lines 0 comments Download
M gn/BUILDCONFIG.gn View 1 2 3 4 2 chunks +39 lines, -11 lines 0 comments Download
M third_party/libwebp/BUILD.gn View 1 2 3 4 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
mtklein_C
This just leaves x86 and MIPS targets to go.
4 years, 3 months ago (2016-08-26 01:33:59 UTC) #8
mtklein_C
ps4 adds at least nominal support for all 6 target cpus. x86 and x86_64 appear ...
4 years, 3 months ago (2016-08-26 13:38:04 UTC) #13
mtklein_C
On 2016/08/26 at 13:38:04, mtklein_C wrote: > ps4 adds at least nominal support for all ...
4 years, 3 months ago (2016-08-26 14:26:53 UTC) #16
herb_g
lgtm
4 years, 3 months ago (2016-08-26 15:07:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279703003/80001
4 years, 3 months ago (2016-08-26 15:12:10 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 15:13:07 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/349cecefe21e2b45acc201290cc4e4fa93b4ad76

Powered by Google App Engine
This is Rietveld 408576698