Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2279603002: add mergeuv test (Closed)

Created:
4 years, 4 months ago by fbarchard1
Modified:
4 years, 3 months ago
Reviewers:
braveyao
CC:
magjed_chromium
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

add mergeuv test Add test for SplitUVPlane and MergeUVPlane Add public methods SplitUVPlanes and MergeUVPlanes based on the optimized assembly functions that already exists. TEST=SplitUVPlane unittest BUG=libyuv:629 R=braveyao@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/dc3a1295becfc4e4215e92f2deebca28243cf5a0

Patch Set 1 #

Patch Set 2 : bump version #

Patch Set 3 : two pass SplitUVRow_NEON #

Patch Set 4 : remove neon optimizations from this cl #

Patch Set 5 : reverse order of tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -2 lines) Patch
M README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M unit_test/planar_test.cc View 1 2 3 4 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fbarchard1
out/Release/libyuv_unittest --gtest_filter=**UVPlane --libyuv_width=1280 --libyuv_height=720 --libyuv_repeat=999 --libyuv_flags=-1 --libyuv_cpu_info=-1 Note: Google Test filter = **UVPlane [==========] Running ...
4 years, 4 months ago (2016-08-25 00:12:41 UTC) #1
braveyao
lgtm
4 years, 4 months ago (2016-08-25 00:17:05 UTC) #2
fbarchard1
ARM C [ OK ] LibYUVPlanarTest.SplitUVPlane (1865 ms) [ OK ] LibYUVPlanarTest.MergeUVPlane (1549 ms) ARM ...
4 years, 4 months ago (2016-08-25 00:26:45 UTC) #3
fbarchard1
[ OK ] LibYUVPlanarTest.SplitUVPlane_Opt (563 ms)
4 years, 4 months ago (2016-08-25 00:49:10 UTC) #5
fbarchard1
lint passes. current speeds tests re-run on ARM with order of tests reversed NEON LibYUVPlanarTest.MergeUVPlane_Opt ...
4 years, 3 months ago (2016-08-25 17:28:46 UTC) #6
fbarchard1
4 years, 3 months ago (2016-08-25 17:29:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
dc3a1295becfc4e4215e92f2deebca28243cf5a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698