content/shell/renderer/webkit_test_runner.cc - Issue 22796028: Updating Chromium to Skia SkBaseDevice/SkBitmapDevice split

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/webkit_test_runner.cc

Issue 22796028: Updating Chromium to Skia SkBaseDevice/SkBitmapDevice split (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODOs Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/renderer/webkit_test_runner.cc

diff --git a/content/shell/renderer/webkit_test_runner.cc b/content/shell/renderer/webkit_test_runner.cc

index 7f11fb96143d3767ec7c0c7bee7a8d4df9b96664..d93a96784a7eb357197e4624bc00e7962f51f498 100644

--- a/content/shell/renderer/webkit_test_runner.cc

+++ b/content/shell/renderer/webkit_test_runner.cc

@@ -110,7 +110,7 @@ void MakeBitmapOpaque(SkBitmap* bitmap) {

#endif

void CopyCanvasToBitmap(SkCanvas* canvas, SkBitmap* snapshot) {

- SkDevice* device = skia::GetTopDevice(*canvas);

+ SkBaseDevice* device = skia::GetTopDevice(*canvas);

const SkBitmap& bitmap = device->accessBitmap(false);

const bool success = bitmap.copyTo(snapshot, SkBitmap::kARGB_8888_Config);

DCHECK(success);

« no previous file with comments | « content/renderer/skia_benchmarking_extension.cc ('k') | media/filters/skcanvas_video_renderer.cc » ('j') | no next file with comments »