Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Side by Side Diff: src/hydrogen.cc

Issue 22796020: Reland "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them.". (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.h ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7261 matching lines...) Expand 10 before | Expand all | Expand 10 after
7272 call->set_position(expr->position()); 7272 call->set_position(expr->position());
7273 return ast_context()->ReturnInstruction(call, expr->id()); 7273 return ast_context()->ReturnInstruction(call, expr->id());
7274 } else { 7274 } else {
7275 // The constructor function is both an operand to the instruction and an 7275 // The constructor function is both an operand to the instruction and an
7276 // argument to the construct call. 7276 // argument to the construct call.
7277 Handle<JSFunction> array_function( 7277 Handle<JSFunction> array_function(
7278 isolate()->global_context()->array_function(), isolate()); 7278 isolate()->global_context()->array_function(), isolate());
7279 CHECK_ALIVE(VisitArgument(expr->expression())); 7279 CHECK_ALIVE(VisitArgument(expr->expression()));
7280 HValue* constructor = HPushArgument::cast(Top())->argument(); 7280 HValue* constructor = HPushArgument::cast(Top())->argument();
7281 CHECK_ALIVE(VisitArgumentList(expr->arguments())); 7281 CHECK_ALIVE(VisitArgumentList(expr->arguments()));
7282 HCallNew* call; 7282 HBinaryCall* call;
7283 if (expr->target().is_identical_to(array_function)) { 7283 if (expr->target().is_identical_to(array_function)) {
7284 Handle<Cell> cell = expr->allocation_info_cell(); 7284 Handle<Cell> cell = expr->allocation_info_cell();
7285 Add<HCheckFunction>(constructor, array_function); 7285 Add<HCheckFunction>(constructor, array_function);
7286 call = new(zone()) HCallNewArray(context, constructor, argument_count, 7286 call = new(zone()) HCallNewArray(context, constructor, argument_count,
7287 cell, expr->elements_kind()); 7287 cell, expr->elements_kind());
7288 } else { 7288 } else {
7289 call = new(zone()) HCallNew(context, constructor, argument_count); 7289 call = new(zone()) HCallNew(context, constructor, argument_count);
7290 } 7290 }
7291 Drop(argument_count); 7291 Drop(argument_count);
7292 call->set_position(expr->position()); 7292 call->set_position(expr->position());
(...skipping 2550 matching lines...) Expand 10 before | Expand all | Expand 10 after
9843 if (ShouldProduceTraceOutput()) { 9843 if (ShouldProduceTraceOutput()) {
9844 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9844 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9845 } 9845 }
9846 9846
9847 #ifdef DEBUG 9847 #ifdef DEBUG
9848 graph_->Verify(false); // No full verify. 9848 graph_->Verify(false); // No full verify.
9849 #endif 9849 #endif
9850 } 9850 }
9851 9851
9852 } } // namespace v8::internal 9852 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen.h ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698