Issue 22796020: Reland "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22796020: Reland "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them.". (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer

Modified:
7 years, 4 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reland "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them.". - Use V8_FINAL and V8_OVERRIDE in Ast classes. - Use V8_FINAL and V8_OVERRIDE in Lithium mips backend. - Use V8_FINAL and V8_OVERRIDE in Lithium arm backend. - Use V8_FINAL and V8_OVERRIDE in Lithium x64 backend. - Use V8_FINAL and V8_OVERRIDE in Lithium ia32 backend. - Use V8_FINAL and V8_OVERRIDE in Lithium classes. - Use V8_FINAL and V8_OVERRIDE in Hydrogen classes. TBR=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16244

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2065 lines, -1896 lines)			Patch
M	src/arm/lithium-arm.h	View	143 chunks	+231 lines, -212 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	14 chunks	+52 lines, -40 lines	0 comments	Download
M	src/arm/lithium-gap-resolver-arm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ast.h	View	100 chunks	+244 lines, -226 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/hydrogen.h	View	23 chunks	+45 lines, -38 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View	254 chunks	+609 lines, -594 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	15 chunks	+57 lines, -43 lines	0 comments	Download
M	src/ia32/lithium-gap-resolver-ia32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.h	View	149 chunks	+232 lines, -213 lines	0 comments	Download
M	src/lithium.h	View	15 chunks	+15 lines, -15 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	14 chunks	+52 lines, -40 lines	0 comments	Download
M	src/mips/lithium-gap-resolver-mips.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/lithium-mips.h	View	141 chunks	+226 lines, -207 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	13 chunks	+49 lines, -37 lines	0 comments	Download
M	src/x64/lithium-gap-resolver-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-x64.h	View	140 chunks	+230 lines, -209 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r16244.

Expand Messages | Collapse Messages