Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: src/hydrogen-instructions.h

Issue 22796011: Clarify side effects of HTransitionElementsKind. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6251 matching lines...) Expand 10 before | Expand all | Expand 10 after
6262 : original_map_(original_map), 6262 : original_map_(original_map),
6263 transitioned_map_(transitioned_map), 6263 transitioned_map_(transitioned_map),
6264 original_map_unique_id_(), 6264 original_map_unique_id_(),
6265 transitioned_map_unique_id_(), 6265 transitioned_map_unique_id_(),
6266 from_kind_(original_map->elements_kind()), 6266 from_kind_(original_map->elements_kind()),
6267 to_kind_(transitioned_map->elements_kind()) { 6267 to_kind_(transitioned_map->elements_kind()) {
6268 SetOperandAt(0, object); 6268 SetOperandAt(0, object);
6269 SetOperandAt(1, context); 6269 SetOperandAt(1, context);
6270 SetFlag(kUseGVN); 6270 SetFlag(kUseGVN);
6271 SetGVNFlag(kChangesElementsKind); 6271 SetGVNFlag(kChangesElementsKind);
6272 if (original_map->has_fast_double_elements()) { 6272 if (!IsSimpleMapChangeTransition(from_kind_, to_kind_)) {
6273 SetGVNFlag(kChangesElementsPointer); 6273 SetGVNFlag(kChangesElementsPointer);
6274 SetGVNFlag(kChangesNewSpacePromotion); 6274 SetGVNFlag(kChangesNewSpacePromotion);
6275 } 6275 }
6276 if (transitioned_map->has_fast_double_elements()) {
6277 SetGVNFlag(kChangesElementsPointer);
6278 SetGVNFlag(kChangesNewSpacePromotion);
6279 }
6280 set_representation(Representation::Tagged()); 6276 set_representation(Representation::Tagged());
6281 } 6277 }
6282 6278
6283 Handle<Map> original_map_; 6279 Handle<Map> original_map_;
6284 Handle<Map> transitioned_map_; 6280 Handle<Map> transitioned_map_;
6285 UniqueValueId original_map_unique_id_; 6281 UniqueValueId original_map_unique_id_;
6286 UniqueValueId transitioned_map_unique_id_; 6282 UniqueValueId transitioned_map_unique_id_;
6287 ElementsKind from_kind_; 6283 ElementsKind from_kind_;
6288 ElementsKind to_kind_; 6284 ElementsKind to_kind_;
6289 }; 6285 };
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
6789 virtual bool IsDeletable() const { return true; } 6785 virtual bool IsDeletable() const { return true; }
6790 }; 6786 };
6791 6787
6792 6788
6793 #undef DECLARE_INSTRUCTION 6789 #undef DECLARE_INSTRUCTION
6794 #undef DECLARE_CONCRETE_INSTRUCTION 6790 #undef DECLARE_CONCRETE_INSTRUCTION
6795 6791
6796 } } // namespace v8::internal 6792 } } // namespace v8::internal
6797 6793
6798 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6794 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698