Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 22796011: Clarify side effects of HTransitionElementsKind. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3067 matching lines...) Expand 10 before | Expand all | Expand 10 after
3078 3078
3079 void HTransitionElementsKind::PrintDataTo(StringStream* stream) { 3079 void HTransitionElementsKind::PrintDataTo(StringStream* stream) {
3080 object()->PrintNameTo(stream); 3080 object()->PrintNameTo(stream);
3081 ElementsKind from_kind = original_map()->elements_kind(); 3081 ElementsKind from_kind = original_map()->elements_kind();
3082 ElementsKind to_kind = transitioned_map()->elements_kind(); 3082 ElementsKind to_kind = transitioned_map()->elements_kind();
3083 stream->Add(" %p [%s] -> %p [%s]", 3083 stream->Add(" %p [%s] -> %p [%s]",
3084 *original_map(), 3084 *original_map(),
3085 ElementsAccessor::ForKind(from_kind)->name(), 3085 ElementsAccessor::ForKind(from_kind)->name(),
3086 *transitioned_map(), 3086 *transitioned_map(),
3087 ElementsAccessor::ForKind(to_kind)->name()); 3087 ElementsAccessor::ForKind(to_kind)->name());
3088 if (IsSimpleMapChangeTransition(from_kind, to_kind)) stream->Add(" (simple)");
3088 } 3089 }
3089 3090
3090 3091
3091 void HLoadGlobalCell::PrintDataTo(StringStream* stream) { 3092 void HLoadGlobalCell::PrintDataTo(StringStream* stream) {
3092 stream->Add("[%p]", *cell()); 3093 stream->Add("[%p]", *cell());
3093 if (!details_.IsDontDelete()) stream->Add(" (deleteable)"); 3094 if (!details_.IsDontDelete()) stream->Add(" (deleteable)");
3094 if (details_.IsReadOnly()) stream->Add(" (read-only)"); 3095 if (details_.IsReadOnly()) stream->Add(" (read-only)");
3095 } 3096 }
3096 3097
3097 3098
(...skipping 899 matching lines...) Expand 10 before | Expand all | Expand 10 after
3997 break; 3998 break;
3998 case kExternalMemory: 3999 case kExternalMemory:
3999 stream->Add("[external-memory]"); 4000 stream->Add("[external-memory]");
4000 break; 4001 break;
4001 } 4002 }
4002 4003
4003 stream->Add("@%d", offset()); 4004 stream->Add("@%d", offset());
4004 } 4005 }
4005 4006
4006 } } // namespace v8::internal 4007 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698