Issue 22796004: Simplify WTF::base64Decode() after r154538

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22796004: Simplify WTF::base64Decode() after r154538 (Closed)

Created:
7 years, 4 months ago by do-not-use

Modified:
7 years, 4 months ago

Reviewers:
eseidel, cevans, abarth-chromium

CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Simplify WTF::base64Decode() after r154538 r154538 increased the complexity of WTF::base64Decode() by introducing a new Base64PaddingValidationPolicy parameter. This patch simplifies the code a bit while achieving the same functionality and matching the corresponding WebKit implementation: http://trac.webkit.org/changeset/153904 Strictly validating padding does not make much sense unless we also validate strictly invalid characters. Therefore, this patch replaces the Base64PaddingValidationPolicy enum with an additional Base64FailOnInvalidCharacterOrExcessPadding value in the Base64DecodePolicy enum. The code is also improved to validate the padding at the end of the decoding loop and also removes a redundant check for the (dataLength % 4 == 1) case. BUG=261200 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155999

Patch Set 1 #

Patch Set 2 : Restore the enum's original name #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -40 lines)			Patch
M	LayoutTests/fast/dom/Window/atob-btoa.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/atob-btoa-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/page/DOMWindowBase64.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/wtf/text/Base64.h	View	1	3 chunks	+7 lines, -13 lines	0 comments	Download
M	Source/wtf/text/Base64.cpp	View	1	3 chunks	+18 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22796004/5001

7 years, 4 months ago (2013-08-13 08:13:42 UTC) #3

Message was sent while issue was closed.

Change committed as 155999

Expand Messages | Collapse Messages