Clean up CPDFSDK_PageView methods.

Clean up CPDFSDK_PageView methods.

This CL cleans up CPDFSDK_PageView::LoadFXAnnots and nits.

Committed: https://pdfium.googlesource.com/pdfium/+/9b57ec9ff50aeab53cf3f028222f69c78840385d

[jaepark, 2016-08-25 21:59:33]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:59:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:07:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:07:26]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-25 22:09:27]

jaepark@google.com changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Lei Zhang, 2016-08-25 22:41:32]

https://codereview.chromium.org/2279563005/diff/1/fpdfsdk/fsdk_mgr.cpp
File fpdfsdk/fsdk_mgr.cpp (right):

https://codereview.chromium.org/2279563005/diff/1/fpdfsdk/fsdk_mgr.cpp#newcod...
fpdfsdk/fsdk_mgr.cpp:725: #ifdef PDF_ENABLE_XFA
A bit weird here. How about:

#ifdef PDF_ENABLE_XFA
return m_page ? m_page->GetPDFPage() : nullptr;
#else
return m_page;
#endif

https://codereview.chromium.org/2279563005/diff/1/fpdfsdk/fsdk_mgr.cpp#newcod...
fpdfsdk/fsdk_mgr.cpp:934: CPDF_Page* pPage = GetPDFPage();
For the non-XFA code path, previously, this code gets called before
SetLock(TRUE). Is that an issue?

[jaepark, 2016-08-25 23:01:19]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 23:01:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 23:13:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 23:13:40]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-25 23:14:14]

https://codereview.chromium.org/2279563005/diff/1/fpdfsdk/fsdk_mgr.cpp
File fpdfsdk/fsdk_mgr.cpp (right):

https://codereview.chromium.org/2279563005/diff/1/fpdfsdk/fsdk_mgr.cpp#newcod...
fpdfsdk/fsdk_mgr.cpp:725: #ifdef PDF_ENABLE_XFA
On 2016/08/25 22:41:31, Lei Zhang wrote:
> A bit weird here. How about:
> 
> #ifdef PDF_ENABLE_XFA
> return m_page ? m_page->GetPDFPage() : nullptr;
> #else
> return m_page;
> #endif

Done.

https://codereview.chromium.org/2279563005/diff/1/fpdfsdk/fsdk_mgr.cpp#newcod...
fpdfsdk/fsdk_mgr.cpp:934: CPDF_Page* pPage = GetPDFPage();
On 2016/08/25 22:41:31, Lei Zhang wrote:
> For the non-XFA code path, previously, this code gets called before
> SetLock(TRUE). Is that an issue?

I don't think this will be an issue. m_bLocked is only used to defer deleting
CPDFSDK_PageView.

[Lei Zhang, 2016-08-25 23:15:29]

lgtm

[jaepark, 2016-08-25 23:20:38]

The CQ bit was checked by jaepark@google.com

[commit-bot: I haz the power, 2016-08-25 23:20:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 23:21:00]

Description was changed from

==========
Clean up CPDFSDK_PageView methods.

This CL cleans up CPDFSDK_PageView::LoadFXAnnots and nits.
==========

to

==========
Clean up CPDFSDK_PageView methods.

This CL cleans up CPDFSDK_PageView::LoadFXAnnots and nits.

Committed:
https://pdfium.googlesource.com/pdfium/+/9b57ec9ff50aeab53cf3f028222f69c78840...
==========

[commit-bot: I haz the power, 2016-08-25 23:21:01]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/9b57ec9ff50aeab53cf3f028222f69c78840...