Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2279563003: Remove a graceful shutdown sequence from TestingPlatformSupport (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 4 months ago
Reviewers:
tkent
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a graceful shutdown sequence from TestingPlatformSupport As discussed in blink-dev@ (https://groups.google.com/a/chromium.org/d/topic/blink-dev/kk4VX0xRB7I/discussion) and platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion), there is no reason we have to shut down the renderer gracefully. It's just causing use-after-free bugs and wasting performance. This CL removes a graceful shutdown sequence from TestingPlatformSupport. BUG=639244 Committed: https://crrev.com/bc13dbaa3f99577e8929e27283d7929d8f844d03 Cr-Commit-Position: refs/heads/master@{#414307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
haraken
PTAL
4 years, 4 months ago (2016-08-25 01:56:43 UTC) #2
tkent
lgtm. After landing this, please watch if LSan bot is happy.
4 years, 4 months ago (2016-08-25 02:18:35 UTC) #3
haraken
> After landing this, please watch if LSan bot is happy. Sure.
4 years, 4 months ago (2016-08-25 02:23:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279563003/1
4 years, 4 months ago (2016-08-25 02:24:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 04:17:54 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 04:20:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc13dbaa3f99577e8929e27283d7929d8f844d03
Cr-Commit-Position: refs/heads/master@{#414307}

Powered by Google App Engine
This is Rietveld 408576698