ash: Convert ShelfDelegate to use WmShelf* instead of Shelf*

ash: Convert ShelfDelegate to use WmShelf* instead of Shelf*

This is a step towards eliminating ash::Shelf.

Also remove ash::shell::ShelfDelegateImpl so we don't have to maintain
multiple stub implementations.

BUG=615502
TEST=ash_unittests

Committed: https://crrev.com/3ad0bed346b3bc79baa6bc79b20468930866a6cc
Cr-Commit-Position: refs/heads/master@{#414142}

[James Cook, 2016-08-24 18:42:15]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-08-24 18:43:12]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-24 18:43:13]

msw, please take a look.

[commit-bot: I haz the power, 2016-08-24 18:43:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-08-24 19:52:41]

lgtm

https://codereview.chromium.org/2279533002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc (right):

https://codereview.chromium.org/2279533002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc:871: if
(ash::ShelfWidget::ShelfAlignmentAllowed()) {
nit: nix curlies

[James Cook, 2016-08-24 19:59:08]

https://codereview.chromium.org/2279533002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc (right):

https://codereview.chromium.org/2279533002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc:871: if
(ash::ShelfWidget::ShelfAlignmentAllowed()) {
On 2016/08/24 19:52:41, msw wrote:
> nit: nix curlies

Done.

[James Cook, 2016-08-24 19:59:14]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-24 19:59:14]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2279533002/#ps20001
(title: "curlies")

[commit-bot: I haz the power, 2016-08-24 19:59:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:03:41]

Description was changed from

==========
ash: Convert ShelfDelegate to use WmShelf* instead of Shelf*

This is a step towards eliminating ash::Shelf.

Also remove ash::shell::ShelfDelegateImpl so we don't have to maintain
multiple stub implementations.

BUG=615502
TEST=ash_unittests
==========

to

==========
ash: Convert ShelfDelegate to use WmShelf* instead of Shelf*

This is a step towards eliminating ash::Shelf.

Also remove ash::shell::ShelfDelegateImpl so we don't have to maintain
multiple stub implementations.

BUG=615502
TEST=ash_unittests

Committed: https://crrev.com/3ad0bed346b3bc79baa6bc79b20468930866a6cc
Cr-Commit-Position: refs/heads/master@{#414142}
==========

[commit-bot: I haz the power, 2016-08-24 21:03:42]

Patchset 2 (id:??) landed as
https://crrev.com/3ad0bed346b3bc79baa6bc79b20468930866a6cc
Cr-Commit-Position: refs/heads/master@{#414142}