Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

Issue 2279513002: DevTools: make hitCount optional & experimental in Profiler domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
index 04832da81bc4c4cd324ca85f5fde0dd1d3383e08..6eea7504619b5b53ea215898a41eeced4850651f 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
@@ -5,7 +5,7 @@
/**
* @constructor
* @extends {WebInspector.ProfileNode}
- * @param {!ProfilerAgent.CPUProfileNode} node
+ * @param {!ProfilerAgent.ProfileNode} node
* @param {number} sampleTime
*/
WebInspector.CPUProfileNode = function(node, sampleTime)
@@ -33,7 +33,7 @@ WebInspector.CPUProfileNode.prototype = {
/**
* @constructor
* @extends {WebInspector.ProfileTreeModel}
- * @param {!ProfilerAgent.CPUProfile} profile
+ * @param {!ProfilerAgent.Profile} profile
*/
WebInspector.CPUProfileDataModel = function(profile)
{
@@ -48,7 +48,7 @@ WebInspector.CPUProfileDataModel = function(profile)
// Current format encodes timestamps as deltas. Start/stop times are in microseconds.
this.profileStartTime = profile.startTime / 1000;
this.profileEndTime = profile.endTime / 1000;
- this.timestamps = this._convertTimestampDeltas(profile);
+ this.timestamps = this._convertTimeDeltas(profile);
}
this.samples = profile.samples;
this.totalHitCount = 0;
@@ -64,54 +64,54 @@ WebInspector.CPUProfileDataModel = function(profile)
WebInspector.CPUProfileDataModel.prototype = {
/**
- * @param {!ProfilerAgent.CPUProfile} profile
+ * @param {!ProfilerAgent.Profile} profile
*/
_compatibilityConversionHeadToNodes: function(profile)
{
if (!profile.head || profile.nodes)
return;
- /** @type {!Array<!ProfilerAgent.CPUProfileNode>} */
+ /** @type {!Array<!ProfilerAgent.ProfileNode>} */
var nodes = [];
convertNodesTree(profile.head);
profile.nodes = nodes;
delete profile.head;
/**
- * @param {!ProfilerAgent.CPUProfileNode} node
+ * @param {!ProfilerAgent.ProfileNode} node
* @return {number}
*/
function convertNodesTree(node)
{
nodes.push(node);
- node.children = (/** @type {!Array<!ProfilerAgent.CPUProfileNode>} */(node.children)).map(convertNodesTree);
+ node.children = (/** @type {!Array<!ProfilerAgent.ProfileNode>} */(node.children)).map(convertNodesTree);
return node.id;
}
},
/**
- * @param {!ProfilerAgent.CPUProfile} profile
+ * @param {!ProfilerAgent.Profile} profile
* @return {?Array<number>}
*/
- _convertTimestampDeltas: function(profile)
+ _convertTimeDeltas: function(profile)
{
- if (!profile.timestampDeltas)
+ if (!profile.timeDeltas)
return null;
var lastTimeUsec = profile.startTime;
- var timestamps = new Array(profile.timestampDeltas.length);
+ var timestamps = new Array(profile.timeDeltas.length);
for (var i = 0; i < timestamps.length; ++i) {
- lastTimeUsec += profile.timestampDeltas[i];
+ lastTimeUsec += profile.timeDeltas[i];
timestamps[i] = lastTimeUsec;
}
return timestamps;
},
/**
- * @param {!Array<!ProfilerAgent.CPUProfileNode>} nodes
+ * @param {!Array<!ProfilerAgent.ProfileNode>} nodes
* @return {!WebInspector.CPUProfileNode}
*/
_translateProfileTree: function(nodes)
{
/**
- * @param {!ProfilerAgent.CPUProfileNode} node
+ * @param {!ProfilerAgent.ProfileNode} node
* @return {boolean}
*/
function isNativeNode(node)
@@ -120,7 +120,7 @@ WebInspector.CPUProfileDataModel.prototype = {
return !!node.callFrame.url && node.callFrame.url.startsWith("native ");
return !!node.url && node.url.startsWith("native ");
}
- /** @type {!Map<number, !ProfilerAgent.CPUProfileNode>} */
+ /** @type {!Map<number, !ProfilerAgent.ProfileNode>} */
var nodeByIdMap = new Map();
for (var i = 0; i < nodes.length; ++i) {
var node = nodes[i];

Powered by Google App Engine
This is Rietveld 408576698