Omnibox: don't assume omnibox has focus in OnAfterPossibleChange().

chrome/browser/ui/omnibox/omnibox_edit_model.cc

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
index 4ee0baf09bcd9a3ca909c61bd67523d2afd9959f..06557cad6dc2b5f57b3696f7364027644d764f14 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
@@ -1032,10 +1032,9 @@ bool OmniboxEditModel::OnAfterPossibleChange(const string16& old_text,
 
   if (text_differs || selection_differs) {
     // Record current focus state for this input if we haven't already.
-    DCHECK_NE(OMNIBOX_FOCUS_NONE, focus_state_);

[Peter Kasting, 2013/08/12 18:58:15]

You should comment about Linux' dumb behavior here.  Better yet, can we make it
so the paste action on Linux gives the omnibox focus before we reach this point?

[samarth, 2013/08/12 19:13:40]

Added comment and crbug.com/271590.  I'll fix Linux in a follow-up.

     if (focus_source_ == INVALID) {
-      focus_source_ = (focus_state_ == OMNIBOX_FOCUS_VISIBLE) ?
-          OMNIBOX : FAKEBOX;
+      focus_source_ = (focus_state_ == OMNIBOX_FOCUS_INVISIBLE) ?
+          FAKEBOX : OMNIBOX;
     }
 
     // Restore caret visibility whenever the user changes text or selection in