Omnibox: don't assume omnibox has focus in OnAfterPossibleChange().

Omnibox: don't assume omnibox has focus in OnAfterPossibleChange().

On Linux, right clicking in the omnibox does not give it focus, so
right-clicking and pasting can change the contents without focus in 
the omnibox. Take out the DCHECK that assumes this cannot happen.

Also, change the focus_source_ to assume the source was OMNIBOX in these cases.

BUG=271462
R=pkasting@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217062

[samarth, 2013-08-12 16:34:04]

Please review.

Thanks,
Samarth

[samarth, 2013-08-12 16:35:51]

mpearson -> pkasting

[Mark P, 2013-08-12 18:56:44]

sgtm, but as you've observed, please wait for Peter because he was the original
reviewer of your change.

--mark

[Peter Kasting, 2013-08-12 18:58:14]

https://codereview.chromium.org/22795005/diff/1/chrome/browser/ui/omnibox/omn...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (left):

https://codereview.chromium.org/22795005/diff/1/chrome/browser/ui/omnibox/omn...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:1035:
DCHECK_NE(OMNIBOX_FOCUS_NONE, focus_state_);
You should comment about Linux' dumb behavior here.  Better yet, can we make it
so the paste action on Linux gives the omnibox focus before we reach this point?

[samarth, 2013-08-12 19:13:40]

https://codereview.chromium.org/22795005/diff/1/chrome/browser/ui/omnibox/omn...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (left):

https://codereview.chromium.org/22795005/diff/1/chrome/browser/ui/omnibox/omn...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:1035:
DCHECK_NE(OMNIBOX_FOCUS_NONE, focus_state_);
On 2013/08/12 18:58:15, Peter Kasting wrote:
> You should comment about Linux' dumb behavior here.  Better yet, can we make
it
> so the paste action on Linux gives the omnibox focus before we reach this
point?

Added comment and crbug.com/271590.  I'll fix Linux in a follow-up.

[Peter Kasting, 2013-08-12 19:27:56]

LGTM

[samarth, 2013-08-12 20:32:01]

Committed patchset #2 manually as r217062 (presubmit successful).