Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2279413002: Clean up: Accessibility no longer needs site instance or transforms (Closed)

Created:
4 years, 3 months ago by dmazzoni
Modified:
4 years, 3 months ago
Reviewers:
no sievers, aboxhall
CC:
aboxhall+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nasko+codewatch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up: Accessibility no longer needs site instance or transforms For a while, BrowserAccessibilityManager needed a way to check whether two frames were in the same site instance, and transform a frame's coordinates from frame-relative coordinates to page-relative coordinates if not. These APIs are no longer necessary because that information is now captured in the accessibility tree. See bug for details. This change just deletes code that's now unused. BUG=618120 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/d748f22c6fa57ce44370686d816500f8cc9cb2aa Cr-Commit-Position: refs/heads/master@{#415451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dmazzoni
aboxhall: accessibility review sievers: owners review
4 years, 3 months ago (2016-08-26 21:35:53 UTC) #3
aboxhall
LGTM :D :D
4 years, 3 months ago (2016-08-29 20:01:35 UTC) #4
aboxhall
LGTM :D :D
4 years, 3 months ago (2016-08-29 20:01:35 UTC) #5
no sievers
lgtm
4 years, 3 months ago (2016-08-30 20:52:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279413002/1
4 years, 3 months ago (2016-08-30 20:53:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 22:06:33 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 22:08:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d748f22c6fa57ce44370686d816500f8cc9cb2aa
Cr-Commit-Position: refs/heads/master@{#415451}

Powered by Google App Engine
This is Rietveld 408576698