Chromium Code Reviews| Index: chrome/common/extensions/extension.cc |
| diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc |
| index df10d27f93dfd53abfa0a659e8cbd112f4dae257..41b752061f4842828d97da9709bfdae3eb2365e7 100644 |
| --- a/chrome/common/extensions/extension.cc |
| +++ b/chrome/common/extensions/extension.cc |
| @@ -42,7 +42,7 @@ |
| #include "grit/generated_resources.h" |
| #endif |
| -namespace keys = extension_manifest_keys; |
| +namespace keys = extensions::manifest_keys; |
| namespace values = extension_manifest_values; |
| namespace errors = extension_manifest_errors; |
| @@ -752,13 +752,15 @@ bool Extension::LoadManifestVersion(string16* error) { |
| } |
| manifest_version_ = manifest_->GetManifestVersion(); |
| - if (creation_flags_ & REQUIRE_MODERN_MANIFEST_VERSION && |
| - manifest_version_ < kModernManifestVersion && |
| - !CommandLine::ForCurrentProcess()->HasSwitch( |
| - switches::kAllowLegacyExtensionManifests)) { |
| + if (manifest_version_ < kModernManifestVersion && |
|
Yoyo Zhou
2013/08/14 21:11:03
This (and manifest.cc) is the only functional chan
|
| + ((creation_flags_ & REQUIRE_MODERN_MANIFEST_VERSION && |
| + !CommandLine::ForCurrentProcess()->HasSwitch( |
| + switches::kAllowLegacyExtensionManifests)) || |
| + GetType() == Manifest::TYPE_PLATFORM_APP)) { |
| *error = ErrorUtils::FormatErrorMessageUTF16( |
| errors::kInvalidManifestVersionOld, |
| - base::IntToString(kModernManifestVersion)); |
| + base::IntToString(kModernManifestVersion), |
| + is_platform_app() ? "apps" : "extensions"); |
| return false; |
| } |