Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3101)

Unified Diff: chrome/common/extensions/extension.cc

Issue 22794012: Rename extension_manifest_keys namespace to extensions::manifest_keys. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/csp_handler.cc ('k') | chrome/common/extensions/extension_file_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index df10d27f93dfd53abfa0a659e8cbd112f4dae257..41b752061f4842828d97da9709bfdae3eb2365e7 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -42,7 +42,7 @@
#include "grit/generated_resources.h"
#endif
-namespace keys = extension_manifest_keys;
+namespace keys = extensions::manifest_keys;
namespace values = extension_manifest_values;
namespace errors = extension_manifest_errors;
@@ -752,13 +752,15 @@ bool Extension::LoadManifestVersion(string16* error) {
}
manifest_version_ = manifest_->GetManifestVersion();
- if (creation_flags_ & REQUIRE_MODERN_MANIFEST_VERSION &&
- manifest_version_ < kModernManifestVersion &&
- !CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kAllowLegacyExtensionManifests)) {
+ if (manifest_version_ < kModernManifestVersion &&
Yoyo Zhou 2013/08/14 21:11:03 This (and manifest.cc) is the only functional chan
+ ((creation_flags_ & REQUIRE_MODERN_MANIFEST_VERSION &&
+ !CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kAllowLegacyExtensionManifests)) ||
+ GetType() == Manifest::TYPE_PLATFORM_APP)) {
*error = ErrorUtils::FormatErrorMessageUTF16(
errors::kInvalidManifestVersionOld,
- base::IntToString(kModernManifestVersion));
+ base::IntToString(kModernManifestVersion),
+ is_platform_app() ? "apps" : "extensions");
return false;
}
« no previous file with comments | « chrome/common/extensions/csp_handler.cc ('k') | chrome/common/extensions/extension_file_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698