Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2279373002:
Refix bug 497949 in a more efficient way that also doesn't rebreak bug 442384. (Closed)
|
Created:
4 years, 3 months ago by Peter Kasting Modified:
4 years, 3 months ago Reviewers:
xiyuan CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefix bug 497949 in a more efficient way that also doesn't rebreak bug 442384.
The original fix meant that SendThemeImage() always fell back to
SendThemeBitmap(), which wasn't desirable.
BUG=442384, 497949
TEST=Navigate to chrome://theme/IDR_SETTINGS_FAVICON@16x. The resulting image should be large.
Committed: https://crrev.com/d05fccdb3f6a779a45c85cb6e7704eab0220cee3
Cr-Commit-Position: refs/heads/master@{#416450}
Patch Set 1 #Patch Set 2 : Add dependency #Patch Set 3 : Update for parent CL test changes #Patch Set 4 : Resync #
Messages
Total messages: 27 (19 generated)
The CQ bit was checked by pkasting@chromium.org to run a CQ dry run
pkasting@chromium.org changed reviewers: + xiyuan@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
This requires https://codereview.chromium.org/2279293004/ to land to fix the test failure it exposed.
The CQ bit was checked by pkasting@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by pkasting@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by pkasting@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org Link to the patchset: https://codereview.chromium.org/2279373002/#ps40001 (title: "Update for parent CL test changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was checked by pkasting@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org Link to the patchset: https://codereview.chromium.org/2279373002/#ps60001 (title: "Resync")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Refix bug 497949 in a more efficient way that also doesn't rebreak bug 442384. The original fix meant that SendThemeImage() always fell back to SendThemeBitmap(), which wasn't desirable. BUG=442384, 497949 TEST=Navigate to chrome://theme/IDR_SETTINGS_FAVICON@16x. The resulting image should be large. ========== to ========== Refix bug 497949 in a more efficient way that also doesn't rebreak bug 442384. The original fix meant that SendThemeImage() always fell back to SendThemeBitmap(), which wasn't desirable. BUG=442384, 497949 TEST=Navigate to chrome://theme/IDR_SETTINGS_FAVICON@16x. The resulting image should be large. Committed: https://crrev.com/d05fccdb3f6a779a45c85cb6e7704eab0220cee3 Cr-Commit-Position: refs/heads/master@{#416450} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d05fccdb3f6a779a45c85cb6e7704eab0220cee3 Cr-Commit-Position: refs/heads/master@{#416450} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
