Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: test/mjsunit/es8/syntactic-tail-call-parsing.js

Issue 2279363002: Remove duplicated code from comma-separated Expression parsing (Closed)
Patch Set: Remove unused message Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/es8/syntactic-tail-call-parsing.js
diff --git a/test/mjsunit/es8/syntactic-tail-call-parsing.js b/test/mjsunit/es8/syntactic-tail-call-parsing.js
index 9ceff9c59649ba1bfa451e9743f8a8e9d0381ef7..6fbdf65157074ee01b991c8926642f9c4724b145 100644
--- a/test/mjsunit/es8/syntactic-tail-call-parsing.js
+++ b/test/mjsunit/es8/syntactic-tail-call-parsing.js
@@ -133,12 +133,6 @@ var SyntaxErrorTests = [
{ src: `()=>{ (1, 2, 3, continue f() ) => {} }`,
err: ` ^^^^^^^^^^^^`,
},
- { src: `()=>{ (... continue f()) => {} }`,
- err: ` ^^^^^^^^^^^^`,
- },
- { src: `()=>{ (a, b, c, ... continue f() ) => {} }`,
- err: ` ^^^^^^^^^^^^`,
- },
{ src: `()=>{ return a <= continue f(); }`,
err: ` ^^^^^^^^^^^^`,
},
@@ -289,6 +283,16 @@ var SyntaxErrorTests = [
},
],
},
+ { msg: "Unexpected token continue",
+ tests: [
+ { src: `()=>{ (... continue f()) => {} }`,
+ err: ` ^^^^^^^^`,
+ },
+ { src: `()=>{ (a, b, c, ... continue f() ) => {} }`,
Dan Ehrenberg 2016/08/26 22:48:53 This is also a worse message. It's only acceptable
nickie 2016/08/29 08:42:59 I can live with it; I think it is a bad error mess
+ err: ` ^^^^^^^^`,
+ },
+ ],
+ },
{ msg: "Undefined label 'foo'",
tests: [
{ src: `()=>{ continue foo () ; }`,

Powered by Google App Engine
This is Rietveld 408576698