Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(53)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/message/arrow-invalid-rest-2.out
Issue
2279363002
:
Remove duplicated code from comma-separated Expression parsing (Closed)
Patch Set: Remove unused message
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
src/messages.h
src/parsing/parser.h
src/parsing/parser-base.h
src/parsing/preparser.h
test/message/arrow-invalid-rest.out
test/message/arrow-invalid-rest-2.out
test/mjsunit/es8/syntactic-tail-call-parsing.js
test/mjsunit/es8/syntactic-tail-call-parsing-sloppy.js
View unified diff
|
Download patch
« src/parsing/parser-base.h
('K') |
« test/message/arrow-invalid-rest.out
('k') |
test/mjsunit/es8/syntactic-tail-call-parsing.js »
('j') |
test/mjsunit/es8/syntactic-tail-call-parsing.js »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
*%(basename)s:7: SyntaxError:
Rest parameter must be an identifier or destructur
ing pattern
1
*%(basename)s:7: SyntaxError:
Unexpected token =
2 var f = (a, ...x = 10) => x;
2 var f = (a, ...x = 10) => x;
3
^^^^^^^^^
3
^
4
SyntaxError: Rest parameter must be an identifier or destructuring pattern
4
SyntaxError: Unexpected token =
OLD
NEW
« src/parsing/parser-base.h
('K') |
« test/message/arrow-invalid-rest.out
('k') |
test/mjsunit/es8/syntactic-tail-call-parsing.js »
('j') |
test/mjsunit/es8/syntactic-tail-call-parsing.js »
('J')
Issue 2279363002: Remove duplicated code from comma-separated Expression parsing (Closed)
Created 4 years, 3 months ago by adamk
Modified 4 years, 3 months ago
Reviewers: Dan Ehrenberg, nickie
Base URL:
Comments: 8
This is Rietveld
408576698
Chromium Code Reviews
Issue 2279363002:
Remove duplicated code from comma-separated Expression parsing (Closed)
