Issue 2279323003: Don't cache the cid of CodeUnits.

Issue 2279323003: Don't cache the cid of CodeUnits. (Closed)

Created:
4 years, 3 months ago by rmacnak

Modified:
4 years, 3 months ago

Reviewers:
Florian Schneider, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't cache the cid of CodeUnits. It is not a predefined class, so its cid may change during precompilation. Committed: https://github.com/dart-lang/sdk/commit/ea6159fb08ae9c8a9c906e4026f3a6efa078dbb5

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	runtime/lib/internal_patch.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	runtime/lib/typed_data.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 7 (4 generated)

rmacnak

Committed patchset #1 (id:1) manually as ea6159fb08ae9c8a9c906e4026f3a6efa078dbb5 (presubmit successful).

4 years, 3 months ago (2016-08-29 16:21:11 UTC) #5

Message was sent while issue was closed.

DBC, does this have a performance impact?