Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2279323002: Revert of Remove the document tagged code as it is unused. (Closed)

Created:
4 years, 3 months ago by npm
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@fpdf_doc
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Remove the document tagged code as it is unused. (patchset #2 id:20001 of https://codereview.chromium.org/2188213002/ ) Reason for revert: Code being used by Android foxit viewer Original issue's description: > Remove the document tagged code as it is unused. > > The fpdf_tagged.h, tagged_int.h and doc_tagged.cpp code is currently unused > and can be removed. > > Committed: https://pdfium.googlesource.com/pdfium/+/dbfc3522a6ee24d17f2c50a5dcc465db52a280ee TBR=thestig@chromium.org,weili@chromium.org,dsinclair@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+665 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A core/fpdfdoc/doc_tagged.cpp View 1 chunk +459 lines, -0 lines 0 comments Download
A core/fpdfdoc/include/fpdf_tagged.h View 1 chunk +93 lines, -0 lines 0 comments Download
A core/fpdfdoc/tagged_int.h View 1 chunk +107 lines, -0 lines 0 comments Download
M pdfium.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
npm
Created Revert of Remove the document tagged code as it is unused.
4 years, 3 months ago (2016-08-26 16:55:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279323002/1
4 years, 3 months ago (2016-08-26 16:55:25 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/builds/1820) linux_xfa on master.tryserver.client.pdfium (JOB_FAILED, ...
4 years, 3 months ago (2016-08-26 16:56:35 UTC) #5
npm
4 years, 3 months ago (2016-08-26 17:34:27 UTC) #7
Message was sent while issue was closed.
Closing and doing revert on Issue 2281083002

Powered by Google App Engine
This is Rietveld 408576698