Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2279313005: Revert of Let PowerSaveBlocker manager anchor view in Java side (Closed)

Created:
4 years, 3 months ago by no sievers
Modified:
4 years, 3 months ago
Reviewers:
Ted C, Theresa, Jinsuk Kim, boliu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Let PowerSaveBlocker manager anchor view in Java side (patchset #3 id:40001 of https://codereview.chromium.org/2259493005/ ) Reason for revert: not needed. doesn't fix the regression. Original issue's description: > Let PowerSaveBlocker manager anchor view in Java side > > This reduces the number of native-to-Java calls by one > with a view to mitigating the benchmark test regression > introduced with https://crrev.com/2103243002. > PowerSaveBlocker was the only class that created an anchor > view during the test. Though the root cause not being > entirely clear yet, having the view created on Java side > can possibly help decrease the browser thread cpu consumption. > > BUG=635515 > TBR=tedchoc@chromium.org > > Committed: https://crrev.com/bc403d8872340a62c310c9665e3b3972344c8c5b > Cr-Commit-Position: refs/heads/master@{#413900} TBR=twellington@chromium.org,boliu@chromium.org,tedchoc@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635515 NOTRY=True Committed: https://crrev.com/eb47bc397e6d21f88b7017bc8b9276d86cd06bad Cr-Commit-Position: refs/heads/master@{#414818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M device/power_save_blocker/android/java/src/org/chromium/device/power_save_blocker/PowerSaveBlocker.java View 3 chunks +2 lines, -4 lines 0 comments Download
M device/power_save_blocker/power_save_blocker_android.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M ui/android/view_android.h View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/android/view_android.cc View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
no sievers
Created Revert of Let PowerSaveBlocker manager anchor view in Java side
4 years, 3 months ago (2016-08-26 20:42:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279313005/1
4 years, 3 months ago (2016-08-26 20:43:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279313005/1
4 years, 3 months ago (2016-08-26 21:36:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 21:41:49 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 21:43:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb47bc397e6d21f88b7017bc8b9276d86cd06bad
Cr-Commit-Position: refs/heads/master@{#414818}

Powered by Google App Engine
This is Rietveld 408576698