Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2279303003: Add link to new ui and feedback button (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add link to new ui and feedback button This feedback button can be removed in the future if need be. The link prefills sane defaults for the bug. BUG=631047 Committed: https://github.com/luci/luci-py/commit/e9e7868ed86aef0c73eb099409de781331d58192

Patch Set 1 #

Patch Set 2 : Address nit #

Total comments: 1

Patch Set 3 : use px #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2884 lines, -2727 lines) Patch
M appengine/swarming/elements/build/elements.html View 1 2 12 chunks +2867 lines, -2727 lines 0 comments Download
M appengine/swarming/elements/res/imp/common/swarming-app.html View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M appengine/swarming/templates/restricted_botslist.html View 1 chunk +2 lines, -0 lines 0 comments Download
M appengine/swarming/templates/user_tasks.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
kjlubick
New feedback button https://screenshot.googleplex.com/5aQAsqKUh92 Link to newui https://screenshot.googleplex.com/JUhwOR4964g
4 years, 3 months ago (2016-08-26 19:58:27 UTC) #2
jcgregorio
lgtm https://codereview.chromium.org/2279303003/diff/20001/appengine/swarming/elements/res/imp/common/swarming-app.html File appengine/swarming/elements/res/imp/common/swarming-app.html (right): https://codereview.chromium.org/2279303003/diff/20001/appengine/swarming/elements/res/imp/common/swarming-app.html#newcode83 appengine/swarming/elements/res/imp/common/swarming-app.html:83: bottom: 1vh; Using vh for a horizontal distance ...
4 years, 3 months ago (2016-08-26 20:10:11 UTC) #4
kjlubick
On 2016/08/26 at 20:10:11, jcgregorio wrote: > lgtm > > https://codereview.chromium.org/2279303003/diff/20001/appengine/swarming/elements/res/imp/common/swarming-app.html > File appengine/swarming/elements/res/imp/common/swarming-app.html (right): ...
4 years, 3 months ago (2016-08-26 20:12:30 UTC) #5
stephana
On 2016/08/26 20:12:30, kjlubick wrote: > On 2016/08/26 at 20:10:11, jcgregorio wrote: > > lgtm ...
4 years, 3 months ago (2016-08-26 20:18:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279303003/40001
4 years, 3 months ago (2016-08-26 20:18:47 UTC) #9
KevinL
lgtm
4 years, 3 months ago (2016-08-26 20:18:49 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-08-26 20:18:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279303003/40001
4 years, 3 months ago (2016-08-26 20:18:58 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 20:22:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/e9e7868ed86aef0c73eb099409de781331d58192

Powered by Google App Engine
This is Rietveld 408576698