content/browser/web_contents/render_view_host_manager.cc - Issue 22793018: <webview>: Implement support for package-local chrome-extension:// URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/render_view_host_manager.cc

Issue 22793018: <webview>: Implement support for package-local chrome-extension:// URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a test to verify that a privileged partition can access a local resource Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/platform_apps/web_view/shim/main.js ('K') | « chrome/test/data/extensions/platform_apps/web_view/shim/manifest.json ('k') | extensions/common/manifest_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/render_view_host_manager.cc

diff --git a/content/browser/web_contents/render_view_host_manager.cc b/content/browser/web_contents/render_view_host_manager.cc

index d8f168f71462b3c4355054431badc82034edbe40..db8d1d0553b3a0b232d98249ae189a0522c0d695 100644

--- a/content/browser/web_contents/render_view_host_manager.cc

+++ b/content/browser/web_contents/render_view_host_manager.cc

@@ -952,7 +952,7 @@ RenderViewHostImpl* RenderViewHostManager::UpdateRendererStateForNavigate(

SetPendingWebUI(entry);

// Make sure the new RenderViewHost has the right bindings.

- if (pending_web_ui())

+ if (pending_web_ui() && !render_view_host_->GetProcess()->IsGuest())

Charlie Reis 2013/09/24 19:41:55 Oops, looks like we missed this one in Hui's CL.

Fady Samuel 2013/09/24 23:05:02 Done.

render_view_host_->AllowBindings(pending_web_ui()->GetBindings());

}