Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2452)

Unified Diff: chrome/common/extensions/webview_accessible_resources_handler.cc

Issue 22793018: <webview>: Implement support for package-local chrome-extension:// URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a test to verify that a privileged partition can access a local resource Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/webview_accessible_resources_handler.cc
diff --git a/chrome/common/extensions/webview_accessible_resources_handler.cc b/chrome/common/extensions/webview_accessible_resources_handler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9bc50eb42acef807adaf4a829f106c972b752748
--- /dev/null
+++ b/chrome/common/extensions/webview_accessible_resources_handler.cc
@@ -0,0 +1,128 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/extensions/webview_accessible_resources_handler.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_util.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
+#include "extensions/common/error_utils.h"
+#include "extensions/common/manifest.h"
+#include "extensions/common/manifest_constants.h"
+
+namespace extensions {
+
+namespace keys = extensions::manifest_keys;
+namespace errors = extensions::manifest_errors;
+
+namespace {
+
+const WebviewAccessibleResourcesInfo* GetResourcesInfo(
+ const Extension* extension) {
+ return static_cast<WebviewAccessibleResourcesInfo*>(
+ extension->GetManifestData(keys::kWebviewAccessibleResources));
+}
+
+} // namespace
+
+WebviewAccessibleResourcesInfo::WebviewAccessibleResourcesInfo() {
+}
+
+WebviewAccessibleResourcesInfo::~WebviewAccessibleResourcesInfo() {
+}
+
+// static
+bool WebviewAccessibleResourcesInfo::IsResourceWebviewAccessible(
+ const Extension* extension,
+ const std::string& partition_id,
+ const std::string& relative_path) {
+ if (extension->manifest_version() < 2)
+ return false;
+
+ const WebviewAccessibleResourcesInfo* info = GetResourcesInfo(extension);
+ if (!info)
+ return false;
+
+ bool partition_is_privileged = false;
+ for (unsigned int i = 0;
+ i < info->webview_privileged_partitions_.size();
+ ++i) {
+ if (MatchPattern(partition_id, info->webview_privileged_partitions_[i])) {
+ partition_is_privileged = true;
+ break;
+ }
+ }
+
+ return partition_is_privileged && extension->ResourceMatches(
+ info->webview_accessible_resources_, relative_path);
+}
+
+// static
+bool WebviewAccessibleResourcesInfo::HasWebviewAccessibleResources(
+ const Extension* extension) {
+ const WebviewAccessibleResourcesInfo* info = GetResourcesInfo(extension);
+ return info && info->webview_accessible_resources_.size() > 0;
+}
+
+WebviewAccessibleResourcesHandler::WebviewAccessibleResourcesHandler() {
+}
+
+WebviewAccessibleResourcesHandler::~WebviewAccessibleResourcesHandler() {
+}
+
+bool WebviewAccessibleResourcesHandler::Parse(Extension* extension,
+ string16* error) {
+ scoped_ptr<WebviewAccessibleResourcesInfo> info(
+ new WebviewAccessibleResourcesInfo);
+ const base::ListValue* url_list = NULL;
+ if (!extension->manifest()->GetList(keys::kWebviewAccessibleResources,
+ &url_list)) {
+ *error = ASCIIToUTF16(errors::kInvalidWebviewAccessibleResourcesList);
+ return false;
+ }
+ for (size_t i = 0; i < url_list->GetSize(); ++i) {
+ std::string relative_path;
+ if (!url_list->GetString(i, &relative_path)) {
+ *error = ErrorUtils::FormatErrorMessageUTF16(
+ errors::kInvalidWebviewAccessibleResource, base::IntToString(i));
+ return false;
+ }
+ URLPattern pattern(URLPattern::SCHEME_EXTENSION);
+ if (pattern.Parse(extension->url().spec()) != URLPattern::PARSE_SUCCESS) {
+ *error = ErrorUtils::FormatErrorMessageUTF16(
+ errors::kInvalidURLPatternError, extension->url().spec());
+ return false;
+ }
+ while (relative_path[0] == '/')
+ relative_path = relative_path.substr(1, relative_path.length() - 1);
+ pattern.SetPath(pattern.path() + relative_path);
+ info->webview_accessible_resources_.AddPattern(pattern);
+ }
+
+ const base::ListValue* partition_list = NULL;
+ if (!extension->manifest()->GetList(keys::kWebviewPrivilegedPartitions,
+ &partition_list)) {
+ *error = ASCIIToUTF16(errors::kInvalidWebviewPrivilegedPartitionList);
+ return false;
+ }
+ for (size_t i = 0; i < partition_list->GetSize(); ++i) {
+ std::string partition_wildcard;
+ if (!partition_list->GetString(i, &partition_wildcard)) {
+ *error = ErrorUtils::FormatErrorMessageUTF16(
+ errors::kInvalidWebviewPrivilegedPartition, base::IntToString(i));
+ return false;
+ }
+ info->webview_privileged_partitions_.push_back(partition_wildcard);
+ }
+ extension->SetManifestData(keys::kWebviewAccessibleResources, info.release());
+ return true;
+}
+
+const std::vector<std::string> WebviewAccessibleResourcesHandler::Keys() const {
+ return SingleKey(keys::kWebviewAccessibleResources);
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698