<webview>: Implement support for package-local chrome-extension:// URLs

chrome/browser/profiles/profile_impl_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl_io_data.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_member.h"
 #include "base/prefs/pref_service.h"
 #include "base/sequenced_task_runner.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/threading/worker_pool.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry_factory.h"
+#include "chrome/browser/extensions/extension_protocols.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/net/chrome_net_log.h"
 #include "chrome/browser/net/chrome_network_delegate.h"
 #include "chrome/browser/net/connect_interceptor.h"
 #include "chrome/browser/net/http_server_properties_manager.h"
 #include "chrome/browser/net/predictor.h"
 #include "chrome/browser/net/sqlite_server_bound_cert_store.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 555 matching lines @@
   // Overwrite the job factory that we inherit from the main context so
   // that we can later provide our own handlers for storage related protocols.
   // Install all the usual protocol handlers unless we are in a browser plugin
   // guest process, in which case only web-safe schemes are allowed.
   if (!partition_descriptor.in_memory) {
     top_job_factory = SetUpJobFactoryDefaults(
         job_factory.Pass(), protocol_handler_interceptor.Pass(),
         network_delegate(),
         ftp_factory_.get());
   } else {
+    job_factory->SetProtocolHandler(

[Charlie Reis, 2013/09/24 19:41:55]

This doesn't make sense to me.

First, the comment suggests that the first branch is for non-guests and the
second branch is for guests.  In that case, it might make sense to selectively
create the extension protocol handler (and not the rest of
SetUpJobFactoryDefaults) here, though we should document that's what we're
doing.

Indeed, that reflects how the code was originally written:
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profi...

However, the check is now about whether the partition is in_memory or not, as of
Nasko's https://chromiumcodereview.appspot.com/11147026.  That means guests
could hit either branch (based on whether the guest is persistant), and
non-guests could hit either branch.  That means this check isn't correct for
what it's being used for.

Nasko, perhaps you could help us understand what the right thing to do is?  Was
this check just a temporary thing before guests could have persistent storage?

[nasko, 2013/09/24 20:02:01]

This indeed looks incorrect and I think it goes back to the original patch
Charlie is pointing to. The logic here (protocol handling) shouldn't be based on
whether a partition is in-memory or not. Protocol handling should be based on
whether this is for a guest process or not, so I think we should fix this here.

[Fady Samuel, 2013/09/24 23:05:02]

Looks like profile_impl_io_data doesn't have enough info to determine for
something is a guest? This looks like it needs a bunch of refactoring. It
probably doesn't make sense to do that refactoring in this CL. Shall I do it in
a separate CL and add a TODO here? Shall I write a separate CL and land that
first?

+          extensions::kExtensionScheme,
+          CreateExtensionProtocolHandler(is_incognito(),
+                                          GetExtensionInfoMap()));

[Charlie Reis, 2013/09/24 19:41:55]

nit: 598-600 all have too much indent.

[Fady Samuel, 2013/09/24 23:05:02]

Done.

     top_job_factory = job_factory.PassAs<net::URLRequestJobFactory>();
   }
   context->SetJobFactory(top_job_factory.Pass());
 
   return context;
 }
 
 ChromeURLRequestContext*
 ProfileImplIOData::InitializeMediaRequestContext(
     ChromeURLRequestContext* original_context,
@@ skipping 89 matching lines @@
     const base::Closure& completion) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   DCHECK(initialized());
 
   DCHECK(transport_security_state());
   // Completes synchronously.
   transport_security_state()->DeleteAllDynamicDataSince(time);
   DCHECK(http_server_properties_manager_);
   http_server_properties_manager_->Clear(completion);
 }