Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: ash/shelf/shelf_layout_manager_unittest.cc

Issue 22793011: ash:Shelf - Enable Alternate Shelf and Side Shelf by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_layout_manager_unittest.cc
diff --git a/ash/shelf/shelf_layout_manager_unittest.cc b/ash/shelf/shelf_layout_manager_unittest.cc
index e44fe347a6885d03fd1e20adaea7bf784794a826..e990f9d25e233eb46f9d90e6216fe86c88e9e20e 100644
--- a/ash/shelf/shelf_layout_manager_unittest.cc
+++ b/ash/shelf/shelf_layout_manager_unittest.cc
@@ -709,14 +709,11 @@ TEST_F(ShelfLayoutManagerTest, MAYBE_SetVisible) {
// Make sure the bounds of the two widgets changed.
launcher_bounds = shelf->GetNativeView()->bounds();
- int bottom =
- screen->GetPrimaryDisplay().bounds().bottom() - shelf_height;
- EXPECT_EQ(launcher_bounds.y(),
- bottom + (manager->GetIdealBounds().height() -
- launcher_bounds.height()) / 2);
+ EXPECT_LT(launcher_bounds.y(),
+ screen->GetPrimaryDisplay().bounds().bottom());
James Cook 2013/08/22 00:19:12 nit: align indent
Harry McCleave 2013/08/27 00:37:00 Done.
status_bounds = shelf->status_area_widget()->GetNativeView()->bounds();
- EXPECT_EQ(status_bounds.y(),
- bottom + shelf_height - status_bounds.height());
+ EXPECT_LT(status_bounds.y(),
+ screen->GetPrimaryDisplay().bounds().bottom());
James Cook 2013/08/22 00:19:12 nit: align indent
Harry McCleave 2013/08/27 00:37:00 Done.
}
// Makes sure LayoutShelf invoked while animating cleans things up.

Powered by Google App Engine
This is Rietveld 408576698