content/browser/webui/url_data_manager_backend.h - Issue 2279293004: Fix DCHECK in debug build when navigating to an unknown chrome://theme/ URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/url_data_manager_backend.h

Issue 2279293004: Fix DCHECK in debug build when navigating to an unknown chrome://theme/ URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace NotifyCanceled() with stored error value Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc ('K') | « chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc ('k') | content/browser/webui/url_data_manager_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/webui/url_data_manager_backend.h

diff --git a/content/browser/webui/url_data_manager_backend.h b/content/browser/webui/url_data_manager_backend.h

index fc8d702af82b3203e7ee91d0a0ad39572e3fe9df..15e64e3c1737ffdf2a2982b1560ad61a2d76f88c 100644

--- a/content/browser/webui/url_data_manager_backend.h

+++ b/content/browser/webui/url_data_manager_backend.h

@@ -52,7 +52,8 @@ class URLDataManagerBackend : public base::SupportsUserData::Data {

// Adds a DataSource to the collection of data sources.

void AddDataSource(URLDataSourceImpl* source);

- // DataSource invokes this. Sends the data to the URLRequest.

+ // DataSource invokes this. Sends the data to the URLRequest. |bytes| may be

+ // null, which signals an error handling the request.

void DataAvailable(RequestID request_id, base::RefCountedMemory* bytes);

static net::URLRequestJob* Factory(net::URLRequest* request,