Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2279273002: Bookmark Suggestions: don't use creation date fallback by default (Closed)

Created:
4 years, 3 months ago by Marc Treib
Modified:
4 years, 3 months ago
Reviewers:
sfiera
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bookmark Suggestions: don't use creation date fallback by default The code stays around for now, so we can turn it on via a variation param if required. BUG=640566 Committed: https://crrev.com/6a34d5dd6f80c32c66f434f989946e2d816b547e Cr-Commit-Position: refs/heads/master@{#414703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Marc Treib
4 years, 3 months ago (2016-08-26 12:57:12 UTC) #3
sfiera
LGTM
4 years, 3 months ago (2016-08-26 13:05:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279273002/1
4 years, 3 months ago (2016-08-26 13:05:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 13:59:20 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 14:01:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a34d5dd6f80c32c66f434f989946e2d816b547e
Cr-Commit-Position: refs/heads/master@{#414703}

Powered by Google App Engine
This is Rietveld 408576698