Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2279263002: Fix conflicting PendingIntent for stop button and swipe away (Closed)

Created:
4 years, 3 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix conflicting PendingIntent for stop button and swipe away Notification PendingIntents having the same name will conflict with each other. This CL fixes the conflict for MediaNotification stop button and swipe away, which now fire different actions but we treat both as ACTION_STOP. BUG=640301 Committed: https://crrev.com/07812a287530bb8629718c2777b07d85c5a51e6a Cr-Commit-Position: refs/heads/master@{#414754}

Patch Set 1 #

Patch Set 2 : split cancel button (pre-L) and swipe away #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Zhiqiang Zhang (Slow)
4 years, 3 months ago (2016-08-26 12:58:46 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years, 3 months ago (2016-08-26 17:09:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279263002/20001
4 years, 3 months ago (2016-08-26 17:10:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 18:28:32 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 18:30:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07812a287530bb8629718c2777b07d85c5a51e6a
Cr-Commit-Position: refs/heads/master@{#414754}

Powered by Google App Engine
This is Rietveld 408576698