Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2279193002: [heap] GCTracer: Properly reset all members for unittests (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] GCTracer: Properly reset all members for unittests BUG=chromium:639818 R=jochen@chromium.org Committed: https://crrev.com/a4a4e7fa97ef6824ea72260201f71e058672433c Cr-Commit-Position: refs/heads/master@{#38930}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/heap/gc-tracer.cc View 2 chunks +17 lines, -8 lines 1 comment Download

Messages

Total messages: 14 (9 generated)
Michael Lippautz
https://codereview.chromium.org/2279193002/diff/1/src/heap/gc-tracer.cc File src/heap/gc-tracer.cc (right): https://codereview.chromium.org/2279193002/diff/1/src/heap/gc-tracer.cc#newcode129 src/heap/gc-tracer.cc:129: current_ = Event(Event::START, NULL, NULL); sorted by members declarations
4 years, 3 months ago (2016-08-26 07:33:52 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-26 07:37:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279193002/1
4 years, 3 months ago (2016-08-26 07:59:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 08:10:19 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 08:10:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4a4e7fa97ef6824ea72260201f71e058672433c
Cr-Commit-Position: refs/heads/master@{#38930}

Powered by Google App Engine
This is Rietveld 408576698