Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2279143002: Stop ignoring the ubuntu precise sysroot. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop ignoring the ubuntu precise sysroot. We added a new sysroot in r414564 and reverted the change in r414594, but we left the .gitignore entries in. I suspect that this is keeping the sysroot directory from being cleaned up, and the license checks are still failing. TBR=thomasanderson@chromium.org, jianli@chromium.org, haraken@chromium.org NOTRY=true BUG=638394 Committed: https://crrev.com/84f0fe90e85ecaabd054fa83e244076af09e1370 Cr-Commit-Position: refs/heads/master@{#414646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279143002/1
4 years, 3 months ago (2016-08-26 03:49:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 03:53:38 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/84f0fe90e85ecaabd054fa83e244076af09e1370 Cr-Commit-Position: refs/heads/master@{#414646}
4 years, 3 months ago (2016-08-26 03:56:18 UTC) #7
Tom (Use chromium acct)
lgtm
4 years, 3 months ago (2016-08-26 03:57:45 UTC) #9
haraken
4 years, 3 months ago (2016-08-26 03:58:22 UTC) #10
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698