third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 2279133002: Remove CSSVariables RuntimeEnabledFeatures flag (status=stable)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 2279133002: Remove CSSVariables RuntimeEnabledFeatures flag (status=stable) (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

index 9c621901859d2b610cc0b928e9a1a4e6d459a95e..0fd280941b5cbf685efc4af8849617ac3c516438 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -107,7 +107,7 @@ static inline bool isValidVisitedLinkProperty(CSSPropertyID id)

void StyleBuilder::applyProperty(CSSPropertyID id, StyleResolverState& state, const CSSValue& value)

{

- if (RuntimeEnabledFeatures::cssVariablesEnabled() && id != CSSPropertyVariable

+ if (id != CSSPropertyVariable

&& (value.isVariableReferenceValue() || value.isPendingSubstitutionValue())) {

const CSSValue* resolvedValue = value.isVariableReferenceValue() ?