Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/css/DOMWindowCSS.cpp

Issue 2279133002: Remove CSSVariables RuntimeEnabledFeatures flag (status=stable) (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Motorola Mobility Inc. All rights reserved. 2 * Copyright (C) 2012 Motorola Mobility Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above 10 * 2. Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 #include "core/css/parser/CSSVariableParser.h" 36 #include "core/css/parser/CSSVariableParser.h"
37 #include "wtf/text/StringBuilder.h" 37 #include "wtf/text/StringBuilder.h"
38 #include "wtf/text/WTFString.h" 38 #include "wtf/text/WTFString.h"
39 39
40 namespace blink { 40 namespace blink {
41 41
42 bool DOMWindowCSS::supports(const String& property, const String& value) 42 bool DOMWindowCSS::supports(const String& property, const String& value)
43 { 43 {
44 CSSPropertyID unresolvedProperty = unresolvedCSSPropertyID(property); 44 CSSPropertyID unresolvedProperty = unresolvedCSSPropertyID(property);
45 if (unresolvedProperty == CSSPropertyInvalid) { 45 if (unresolvedProperty == CSSPropertyInvalid) {
46 if (RuntimeEnabledFeatures::cssVariablesEnabled() && CSSVariableParser:: isValidVariableName(property)) { 46 if (CSSVariableParser::isValidVariableName(property)) {
47 MutableStylePropertySet* dummyStyle = MutableStylePropertySet::creat e(HTMLStandardMode); 47 MutableStylePropertySet* dummyStyle = MutableStylePropertySet::creat e(HTMLStandardMode);
48 return CSSParser::parseValueForCustomProperty(dummyStyle, "--valid", value, false, 0); 48 return CSSParser::parseValueForCustomProperty(dummyStyle, "--valid", value, false, 0);
49 } 49 }
50 return false; 50 return false;
51 } 51 }
52 52
53 ASSERT(CSSPropertyMetadata::isEnabledProperty(unresolvedProperty)); 53 ASSERT(CSSPropertyMetadata::isEnabledProperty(unresolvedProperty));
54 54
55 // This will return false when !important is present 55 // This will return false when !important is present
56 MutableStylePropertySet* dummyStyle = MutableStylePropertySet::create(HTMLSt andardMode); 56 MutableStylePropertySet* dummyStyle = MutableStylePropertySet::create(HTMLSt andardMode);
57 return CSSParser::parseValue(dummyStyle, unresolvedProperty, value, false, 0 ); 57 return CSSParser::parseValue(dummyStyle, unresolvedProperty, value, false, 0 );
58 } 58 }
59 59
60 bool DOMWindowCSS::supports(const String& conditionText) 60 bool DOMWindowCSS::supports(const String& conditionText)
61 { 61 {
62 return CSSParser::parseSupportsCondition(conditionText); 62 return CSSParser::parseSupportsCondition(conditionText);
63 } 63 }
64 64
65 String DOMWindowCSS::escape(const String& ident) 65 String DOMWindowCSS::escape(const String& ident)
66 { 66 {
67 StringBuilder builder; 67 StringBuilder builder;
68 serializeIdentifier(ident, builder); 68 serializeIdentifier(ident, builder);
69 return builder.toString(); 69 return builder.toString();
70 } 70 }
71 71
72 } // namespace blink 72 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698