Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: components/ntp_snippets/content_suggestions_metrics.cc

Issue 2279123002: [Sync] Initial implementation of foreign sessions suggestions provider. (Closed)
Patch Set: Updating for comments, again! Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/category_factory.cc ('k') | components/ntp_snippets/features.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/content_suggestions_metrics.cc
diff --git a/components/ntp_snippets/content_suggestions_metrics.cc b/components/ntp_snippets/content_suggestions_metrics.cc
index b83522a73a3d6a7768dbff941e392f829b0d8eac..2876eac92cce11a637ba5c72224fec193cff2a6c 100644
--- a/components/ntp_snippets/content_suggestions_metrics.cc
+++ b/components/ntp_snippets/content_suggestions_metrics.cc
@@ -45,6 +45,8 @@ const char kHistogramMoreButtonClicked[] =
const char kPerCategoryHistogramFormat[] = "%s.%s";
+// Each suffix here should correspond to an entry under histogram suffix
+// ContentSuggestionCategory in histograms.xml.
std::string GetCategorySuffix(Category category) {
static_assert(
std::is_same<decltype(category.id()), typename base::underlying_type<
@@ -64,6 +66,8 @@ std::string GetCategorySuffix(Category category) {
return "Bookmarks";
case KnownCategories::PHYSICAL_WEB_PAGES:
return "PhysicalWeb";
+ case KnownCategories::FOREIGN_TABS:
+ return "ForeignTabs";
case KnownCategories::ARTICLES:
return "Articles";
case KnownCategories::LOCAL_CATEGORIES_COUNT:
« no previous file with comments | « components/ntp_snippets/category_factory.cc ('k') | components/ntp_snippets/features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698