Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: components/ntp_snippets/features.h

Issue 2279123002: [Sync] Initial implementation of foreign sessions suggestions provider. (Closed)
Patch Set: Adding sessions deps to BUILD.gn Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/features.h
diff --git a/components/ntp_snippets/features.h b/components/ntp_snippets/features.h
index 655b99f0d8afc2047d93a32e2083cecbb3d1e248..3b839ec2c5d7cecc4f98bc9bf5626c9c99b8afe1 100644
--- a/components/ntp_snippets/features.h
+++ b/components/ntp_snippets/features.h
@@ -5,6 +5,8 @@
#ifndef COMPONENTS_NTP_SNIPPETS_FEATURES_H_
#define COMPONENTS_NTP_SNIPPETS_FEATURES_H_
+#include <string>
+
#include "base/feature_list.h"
namespace ntp_snippets {
@@ -15,6 +17,7 @@ extern const base::Feature kBookmarkSuggestionsFeature;
extern const base::Feature kRecentOfflineTabSuggestionsFeature;
extern const base::Feature kDownloadSuggestionsFeature;
extern const base::Feature kPhysicalWebPageSuggestionsFeature;
+extern const base::Feature kForeignSessionsSuggestionsFeature;
// Feature to allow the 'save to offline' option to appear in the snippets
// context menu.
@@ -24,6 +27,11 @@ extern const base::Feature kSaveToOfflineFeature;
// false, all the per-provider features are ignored.
extern const base::Feature kContentSuggestionsFeature;
+// Returns a feature param as an int instead of a string.
+int GetParamAsInt(const base::Feature& feature,
+ const std::string& param_name,
+ const int default_value);
Marc Treib 2016/09/16 12:26:48 nit: "const" doesn't do anything here
tschumann 2016/09/16 13:33:20 right. You can keep it in the definition to preven
skym 2016/09/16 18:18:48 Removed from declaration only.
+
} // namespace ntp_snippets
#endif // COMPONENTS_NTP_SNIPPETS_FEATURES_H_

Powered by Google App Engine
This is Rietveld 408576698