Method to convet base::Time to Java timestamp.

base/time/time.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/time/time.h"
 
 #include <math.h>
 #include <limits>
 
 #include "base/float_util.h"
@@ skipping 120 matching lines @@
     return 0;
   }
   if (is_max()) {
     // Preserve max without offset to prevent overflow.
     return std::numeric_limits<double>::max();
   }
   return (static_cast<double>(us_ - kTimeTToMicrosecondsOffset) /
           kMicrosecondsPerMillisecond);
 }
 
+int64 Time::ToJavaTime() const {

[Mark Mentovai, 2013/09/20 15:46:25]

It looks like, given this and ToJsTime’s equivalence, you could use a templated
friend or private member function to do the internal work, and have ToJsTime and
ToJavaTime call that internal helper.

I won’t insist on this as long as there are only two, but I would insist if
there were three.

[apiccion, 2013/09/20 18:21:48]

Thank you!

On 2013/09/20 15:46:25, Mark Mentovai wrote:

+  if (is_null()) {
+    return 0;

[Mark Mentovai, 2013/09/20 15:46:25]

You seem to have copied this from ToJsTime, but you lost the comment that came
with this return statement.

[apiccion, 2013/09/20 18:21:48]

Done.

+  }
+  if (is_max()) {
+    // Preserve max without offset to prevent overflow.
+    return std::numeric_limits<long>::max();

[Mark Mentovai, 2013/09/20 15:46:25]

long is the wrong type here.

[apiccion, 2013/09/20 18:21:48]

Done.

+  }
+  return ((us_ - kTimeTToMicrosecondsOffset) /
+          kMicrosecondsPerMillisecond);
+}
+
 // static
 Time Time::UnixEpoch() {
   Time time;
   time.us_ = kTimeTToMicrosecondsOffset;
   return time;
 }
 
 Time Time::LocalMidnight() const {
   Exploded exploded;
   LocalExplode(&exploded);
@@ skipping 35 matching lines @@
   return is_in_range(month, 1, 12) &&
          is_in_range(day_of_week, 0, 6) &&
          is_in_range(day_of_month, 1, 31) &&
          is_in_range(hour, 0, 23) &&
          is_in_range(minute, 0, 59) &&
          is_in_range(second, 0, 60) &&
          is_in_range(millisecond, 0, 999);
 }
 
 }  // namespace base