Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 22791004: Add toSVGStopElement(Node* node) to clean-up a static_cast<SVGStopElement*> (Closed)

Created:
7 years, 4 months ago by gyuyoung-inactive
Modified:
7 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add toSVGStopElement(Node* node) to clean-up a static_cast<SVGStopElement*> This patch adds toSVGStopElement(Node* node) in order to remove remained static_cast<SVGStopElement*>. BUG = N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStopElement.h View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gyuyoung-inactive
As addressed on 23279010, I move this patch to new CL.
7 years, 4 months ago (2013-08-19 00:13:13 UTC) #1
gyuyoung-inactive
Add tkent as reviewer.
7 years, 4 months ago (2013-08-19 00:13:30 UTC) #2
tkent
lgtm
7 years, 4 months ago (2013-08-19 00:17:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/22791004/1
7 years, 4 months ago (2013-08-19 00:17:49 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 01:11:32 UTC) #5
Message was sent while issue was closed.
Change committed as 156274

Powered by Google App Engine
This is Rietveld 408576698