tests/compiler/dart2js/mirror_helper_unique_minification_test.dart - Issue 22791002: Add renames in output when using the mirror helper library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/mirror_helper_unique_minification_test.dart

Issue 22791002: Add renames in output when using the mirror helper library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments and fixed some latent bugs in other parts of the code. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests/compiler/dart2js/mirror_helper_test.dart ('K') | « tests/compiler/dart2js/mirror_helper_test.dart ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/mirror_helper_unique_minification_test.dart

diff --git a/tests/compiler/dart2js/mirror_helper_unique_minification_test.dart b/tests/compiler/dart2js/mirror_helper_unique_minification_test.dart

index 35885cde245992bd9479c9734e44c7497ff9eda0..972bccd7ae319f073acee09299bc8596d571e244 100644

--- a/tests/compiler/dart2js/mirror_helper_unique_minification_test.dart

+++ b/tests/compiler/dart2js/mirror_helper_unique_minification_test.dart

@@ -33,8 +33,9 @@ void testUniqueMinification() {

DartBackend backend = compiler.backend;

Map<Node, String> renames = backend.renames;

- //'Foo' appears twice, so toSet() reduces the length by 1.

- Expect.equals(renames.values.toSet().length, renames.values.length - 1);

+ //'Foo' appears twice, so toSet() reduces the length by 1,

+ // and the extra code from mirror_helper.dart adds 9 duplicates.

+ Expect.equals(renames.values.toSet().length, renames.values.length - 10);

}

void testNoUniqueMinification() {

« tests/compiler/dart2js/mirror_helper_test.dart ('K') | « tests/compiler/dart2js/mirror_helper_test.dart ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »