sdk/lib/_internal/compiler/implementation/mirrors_used.dart - Issue 22791002: Add renames in output when using the mirror helper library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors_used.dart

Issue 22791002: Add renames in output when using the mirror helper library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments and fixed some latent bugs in other parts of the code. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/mirror_renamer/renamer.dart ('K') | « sdk/lib/_internal/compiler/implementation/mirror_renamer/renamer.dart ('k') | sdk/lib/_internal/compiler/implementation/scanner/listener.dart » ('j') | tests/compiler/dart2js/dart_backend_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors_used.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors_used.dart b/sdk/lib/_internal/compiler/implementation/mirrors_used.dart

index 9c8df9cab5fbe0355c21246f47bedc7b714f2344..144f3950d2abbe5d4f3dff27f6c412c95e5639a5 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors_used.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors_used.dart

@@ -120,8 +120,11 @@ class MirrorUsageAnalyzerTask extends CompilerTask {

/// the resolver to suppress hints about using new Symbol or

/// MirrorSystem.getName.

bool hasMirrorUsage(Element element) {

- return librariesWithUsage != null

- && librariesWithUsage.contains(element.getLibrary());

+ LibraryElement library = element.getLibrary();

+ // Internal libraries always have implicit mirror usage.

+ return library.isInternalLibrary

+ || (librariesWithUsage != null

+ && librariesWithUsage.contains(library));

}

/// Call-back from the resolver to analyze MirorsUsed annotations. The result