Add renames in output when using the mirror helper library.

sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart_backend;
 
 class LocalPlaceholder {
   final String identifier;
   final Set<Node> nodes;
   LocalPlaceholder(this.identifier) : nodes = new Set<Node>();
@@ skipping 89 matching lines @@
           collector.tryMakeLocalPlaceholder(element, node.selector);
         } else {
           assert(node.selector is FunctionExpression);
         }
       }
     }
   }
 
   visitStaticSend(Send node) {
     final element = elements[node];
-    backend.registerStaticSend(element, node);
+    collector.backend.registerStaticSend(element, node);

[ahe, 2013/08/19 15:34:06]

I don't understand this change.

[zarah, 2013/08/20 14:08:17]

Since the backend is now needed in the collector as well as the SendVisitor it
seemed superfluous to have a backend getter both places, so I moved it into the
collecor, but apparently forgot to delete it in the SendVisitor. This is now
done.

 
     if (Elements.isUnresolved(element)
         || identical(element, compiler.assertMethod)) {
       return;
     }
     if (element.isConstructor() || element.isFactoryConstructor()) {
       // Rename named constructor in redirection position:
       // class C { C.named(); C.redirecting() : this.named(); }
       if (node.receiver is Identifier
           && node.receiver.asIdentifier().isThis()) {
@@ skipping 33 matching lines @@
   final List<DeclarationTypePlaceholder> declarationTypePlaceholders;
   final Map<String, Set<Identifier>> memberPlaceholders;
   final Map<Element, List<ConstructorPlaceholder>> constructorPlaceholders;
   Map<String, LocalPlaceholder> currentLocalPlaceholders;
   Element currentElement;
   FunctionElement topmostEnclosingFunction;
   TreeElements treeElements;
 
   LibraryElement get coreLibrary => compiler.coreLibrary;
   FunctionElement get entryFunction => compiler.mainApp.find(Compiler.MAIN);
+  DartBackend get backend => compiler.backend;
 
   get currentFunctionScope => functionScopes.putIfAbsent(
       topmostEnclosingFunction, () => new FunctionScope());
 
   PlaceholderCollector(this.compiler, this.fixedMemberNames, this.elementAsts) :
       nullNodes = new Set<Node>(),
       unresolvedNodes = new Set<Node>(),
       elementNodes = new Map<Element, Set<Node>>(),
       functionScopes = new Map<FunctionElement, FunctionScope>(),
       privateNodes = new Map<LibraryElement, Set<Identifier>>(),
@@ skipping 357 matching lines @@
       }
     }
     node.visitChildren(this);
   }
 
   visitFunctionExpression(FunctionExpression node) {
     bool isKeyword(Identifier id) =>
         id != null && Keyword.keywords[id.source.slowToString()] != null;
 
     Element element = treeElements[node];
+    if (element == compiler.mirrorHelperFunction) {
+      backend.registerHelperFunction(element, node);
+    }
     // May get null here in case of A(int this.f());
     if (element != null) {
       // Rename only local functions.
       if (topmostEnclosingFunction == null) {
         topmostEnclosingFunction = element;
       }
       if (!identical(element, currentElement)) {
         if (node.name != null) {
           assert(node.name is Identifier);
           tryMakeLocalPlaceholder(element, node.name);
@@ skipping 67 matching lines @@
 
   visitBlock(Block node) {
     for (Node statement in node.statements.nodes) {
       if (statement is VariableDefinitions) {
         makeVarDeclarationTypePlaceholder(statement);
       }
     }
     node.visitChildren(this);
   }
 }